Bug 2278676 - Provider mode. Create StorageClient form. IP is not allowed without https prefix
Summary: Provider mode. Create StorageClient form. IP is not allowed without https prefix
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenShift Data Foundation
Classification: Red Hat Storage
Component: management-console
Version: 4.16
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: ODF 4.16.0
Assignee: Bipul Adhikari
QA Contact: Daniel Osypenko
URL:
Whiteboard: isf-provider
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-02 16:51 UTC by Daniel Osypenko
Modified: 2024-07-17 13:21 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-07-17 13:21:50 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github red-hat-storage odf-console pull 1381 0 None open [release-4.16] Bug 2278676: Fixes provider endpoint validations 2024-05-14 10:33:35 UTC
Github red-hat-storage odf-console pull 1382 0 None open [release-4.16-compatibility] Bug 2278676: Fixes provider endpoint validations 2024-05-14 05:15:40 UTC
Red Hat Product Errata RHSA-2024:4591 0 None None None 2024-07-17 13:21:56 UTC

Description Daniel Osypenko 2024-05-02 16:51:44 UTC
Created attachment 2030898 [details]
url-not-valid

Description of problem (please be detailed as possible and provide log
snippests):

Form requests to provide a proper URL with a valid port when IPv4:port is set.
It appears that "https" is a mandatory prefix for endpoint, which is neither intuitive, nor required by StorageClient CR

requirements to endpoint -> 
// the controller of storageclient is running in same namespace and should be able to resolve the endpoint
// via servicename:serviceport irrespective of clusterip/nodeport/lb
storageClient.Spec.StorageProviderEndpoint = fmt.Sprintf("%s:%d", ocsProviderServerName, ocsProviderServicePort)

source -> 
https://github.com/red-hat-storage/ocs-operator/commit/3024804b8038acfcb5d224c2016ffa440b1115a2#diff-3a3043bcbec115677bf1cd899c5c562a02eb74b2c874f80b42ff8bd6880c41f4


We need to add (?) msg explaining IP or URL format to user.


Version of all relevant components (if applicable):
Provider - OCP 4.16.0-ec.5, ODF 4.16.0-86
Client - OCP 4.16.0-ec.5, ODF 4.16.0-86

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?

Can block user to create StorageClient via UI, unless "https://" will be used

Is there any workaround available to the best of your knowledge?
use CR and apply via CLI

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
yes

Can this issue reproduce from the UI?
yes

If this is a regression, please provide more details to justify this:
new feature

Steps to Reproduce:
1. Open management-console web-page, login. OCP 
2. Navigate to Storage Clients page and click on Create Storage Client
3. Fill the form


Actual results:
No hints on valid URL form
Enter 52.118.43.163:31659, see "Please provide a proper URL with valid port"

Expected results:
Hint (?) exists. User is notified with the URL field requirements
Enter 52.118.43.163:31659, see "Storage Client created" notification

Additional info:

Comment 9 Daniel Osypenko 2024-05-20 13:04:02 UTC
ODF 4.16.0-101 Fixed
Plugin enabled form (screenshot) https://ibm.box.com/s/hfx0zjqni6m950govrxbv65mdykyhgfj
Plugin disabled form (screenrecording) https://ibm.box.com/s/hfx0zjqni6m950govrxbv65mdykyhgfj

Comment 11 errata-xmlrpc 2024-07-17 13:21:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.16.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:4591


Note You need to log in before you can comment on or make changes to this bug.