Bug 227868 - Suggested changes to gtk2.spec
Suggested changes to gtk2.spec
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: gtk2 (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthias Clasen
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-02-08 12:55 EST by Stepan Kasal
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-09 10:14:32 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
sucggested chages (743 bytes, patch)
2007-02-08 12:55 EST, Stepan Kasal
no flags Details | Diff

  None (edit)
Description Stepan Kasal 2007-02-08 12:55:34 EST
I saw how gtk2.spec calls autotools, and I suggest the chages attached below.
Rationale:
1) the comment now reflects the current set of patches
2) autoheader calls autoconf, which reads aclocal.m4, so it is safer to call it
after aclocal-1.7
3) I suggest to remove the tricks with autoconf-2.53 and such, because
autoheader calls the default autoconf anyway, and having a mismatch of the
versions seem dangerous.

(No, I experienced no actual problems, I just think the above changes makes the
spec file less fragile.)
Comment 1 Stepan Kasal 2007-02-08 12:55:34 EST
Created attachment 147676 [details]
sucggested chages
Comment 2 Matthias Clasen 2007-02-08 16:02:49 EST
sure, looks fine. Will you build that ?
Comment 3 Stepan Kasal 2007-02-09 10:14:32 EST
Done, 2.10.9-4.fc7 built.
Thanks for your review.

Note You need to log in before you can comment on or make changes to this bug.