Bug 227884
| Summary: | RHEL-4.4 DST changes required for libgcj | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | Alan Matsuoka <alanm> | ||||
| Component: | gcc | Assignee: | Jakub Jelinek <jakub> | ||||
| Status: | CLOSED ERRATA | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 4.4 | CC: | aoliva, ghagstedt, tao, vanhoof | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | RHBA-2007-0080 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-03-05 15:07:42 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 227983 | ||||||
| Attachments: |
|
||||||
|
Description
Alan Matsuoka
2007-02-08 19:27:07 UTC
Created attachment 147693 [details]
libgcj patch for DST timezone changes
That patch was against trunk and, furthermore, isn't the latest. There is a newer patch against trunk at http://gcc.gnu.org/ml/gcc-patches/2007-02/msg00800.html which I'm going to backport. Apparently there are several bugs in the TimeZone code, but those need a lot of work and aren't appropriate for the update now, so guess just the updated tables should be enough for RHEL4.5. Simple testcase for QA purposes:
cat > RHBZ227884.java <<\EOF
import java.util.*;
final class RHBZ227884
{
private static void test (TimeZone t)
{
Calendar cal = Calendar.getInstance (t);
int errors = 0;
cal.set (Calendar.MILLISECOND, 0);
cal.set (2007, Calendar.MARCH, 11, 1, 59, 59);
if (cal.get(Calendar.DST_OFFSET) != 0
|| cal.get(Calendar.ZONE_OFFSET) != -5 * 3600000)
errors |= 1;
cal.set (2007, Calendar.MARCH, 11, 3, 00, 00);
if (cal.get(Calendar.DST_OFFSET) != 3600000
|| cal.get(Calendar.ZONE_OFFSET) != -5 * 3600000)
errors |= 2;
cal.set (2007, Calendar.APRIL, 25, 3, 00, 00);
if (cal.get(Calendar.DST_OFFSET) != 3600000
|| cal.get(Calendar.ZONE_OFFSET) != -5 * 3600000)
errors |= 4;
cal.set (2007, Calendar.NOVEMBER, 4, 0, 59, 59);
if (cal.get(Calendar.DST_OFFSET) != 3600000
|| cal.get(Calendar.ZONE_OFFSET) != -5 * 3600000)
errors |= 8;
cal.set (2007, Calendar.NOVEMBER, 4, 2, 00, 00);
if (cal.get(Calendar.DST_OFFSET) != 0
|| cal.get(Calendar.ZONE_OFFSET) != -5 * 3600000)
errors |= 16;
if (errors > 0)
System.out.println ("FAIL: error bitmask " + errors);
else
System.out.println ("PASS: no errors were found");
}
public static void main (String[]args)
{
test (TimeZone.getTimeZone ("America/New_York"));
TimeZone t = new SimpleTimeZone (-5000 * 3600, "EST",
Calendar.MARCH, 2, Calendar.SUNDAY,
2000 * 3600,
Calendar.NOVEMBER, 1, Calendar.SUNDAY,
2000 * 3600);
test (t);
}
}
EOF
gcj -C RHBZ227884.java
gij RHBZ227884
should print:
PASS: no errors were found
PASS: no errors were found
while with non-fixed libgcj it prints:
FAIL: error bitmask 10
PASS: no errors were found
In gcc-3.4.6-7. What am I missing? [root@quark ~]# gcj -C RHBZ227884.java [root@quark ~]# gij RHBZ227884 FAIL: error bitmask 14 FAIL: error bitmask 14 [root@quark ~]# gcj --version gcj (GCC) 3.4.6 20060404 (Red Hat 3.4.6-7) Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. [root@quark ~]# rpm -qa | egrep "gcc|gcj" java-1.4.2-gcj-compat-devel-1.4.2.0-27jpp libgcc-3.4.6-7 gcc-java-3.4.6-7 libgcj-devel-3.4.6-7 libgcj-3.4.6-7 gcc-3.4.6-7 java-1.4.2-gcj-compat-1.4.2.0-27jpp gcc-c++-3.4.6-7 An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0080.html Is there a way to download these 15 packages in bulk, or do I have to search for each one manually in the simple package search one at a time for every architecture? disregard. I see they have been added to up2date. Apologies. |