Spec URL: https://topazus.fedorapeople.org/deepin-util-dfm.spec SRPM URL: https://topazus.fedorapeople.org/deepin-util-dfm-1.2.23-1.fc39.src.rpm Description: Utilities of deepin file manager Fedora Account System Username: topazus A dependency of deepin-file-manager. https://github.com/linuxdeepin/dde-file-manager/blob/3a4b50c84819ba09dd6ff7edc6965e1f02b8cc37/src/dfm-base/CMakeLists.txt#L51-L53
Copr build: https://copr.fedorainfracloud.org/coprs/build/7401398 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2278891-deepin-util-dfm/fedora-rawhide-x86_64/07401398-deepin-util-dfm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://topazus.fedorapeople.org/deepin-util-dfm.spec SRPM URL: https://topazus.fedorapeople.org/deepin-util-dfm-1.2.23-1.fc39.src.rpm
Created attachment 2031196 [details] The .spec file difference from Copr build 7401398 to 7403363
Copr build: https://copr.fedorainfracloud.org/coprs/build/7403363 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2278891-deepin-util-dfm/fedora-rawhide-x86_64/07403363-deepin-util-dfm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
fix directory owner. Spec URL: https://topazus.fedorapeople.org/deepin-util-dfm.spec SRPM URL: https://topazus.fedorapeople.org/deepin-util-dfm-1.2.23-1.fc39.src.rpm
Created attachment 2031198 [details] The .spec file difference from Copr build 7403363 to 7404226
Copr build: https://copr.fedorainfracloud.org/coprs/build/7404226 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2278891-deepin-util-dfm/fedora-rawhide-x86_64/07404226-deepin-util-dfm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
split into dfm-burn, dfm-io and dfm-mount. Spec URL: https://topazus.fedorapeople.org/deepin-util-dfm.spec SRPM URL: https://topazus.fedorapeople.org/deepin-util-dfm-1.2.23-1.fc39.src.rpm
[fedora-review-service-build]
Fix spelling. Spec URL: https://topazus.fedorapeople.org/deepin-util-dfm.spec SRPM URL: https://topazus.fedorapeople.org/deepin-util-dfm-1.2.23-1.fc39.src.rpm
+ package name is OK + license is acceptable for Fedora: GPL-3.0-or-later AND ClArtistic AND BSD-3-Clause AND BSD-4-Clause + builds and installs OK + BR/P/R look correct + no scriptlets needed or present + rpmlint finds no big issue --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "Creative Commons Attribution 4.0 and/or Creative Commons CC0 1.0 and/or GNU General Public License, Version 3 and/or MIT License", "Creative Commons Attribution 4.0", "*No copyright* Creative Commons CC0 1.0", "*No copyright* Clarified Artistic License", "GNU General Public License, Version 3", "*No copyright* MIT License", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "BSD 2-Clause License", "BSD 2-Clause License and/or BSD 2-clause NetBSD License", "Historical Permission Notice and Disclaimer - sell variant [generated file]", "BSD 3-Clause License", "BSD-4-Clause (University of California-Specific)", "BSD 2-clause NetBSD License and/or BSD 4-Clause License", "MIT License". 67 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/deepin-util-dfm/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64, /usr/src, /usr/lib, /usr/share, /usr/share/doc, /usr/lib64/pkgconfig, /usr, /usr/src/debug, /usr/share/licenses, /usr/lib64/cmake, /usr/include [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64, /usr, /usr/src, /usr/lib, /usr/src/debug, /usr/share/licenses, /usr/share, /usr/lib64/cmake, /usr/share/doc, /usr/include, /usr/lib64/pkgconfig [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4203 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dfm-burn , dfm-burn-devel , dfm-io , dfm-io-devel , dfm-mount , dfm-mount-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: dfm-burn-1.2.23-1.fc41.x86_64.rpm dfm-burn-devel-1.2.23-1.fc41.x86_64.rpm dfm-io-1.2.23-1.fc41.x86_64.rpm dfm-io-devel-1.2.23-1.fc41.x86_64.rpm dfm-mount-1.2.23-1.fc41.x86_64.rpm dfm-mount-devel-1.2.23-1.fc41.x86_64.rpm deepin-util-dfm-debuginfo-1.2.23-1.fc41.x86_64.rpm deepin-util-dfm-debugsource-1.2.23-1.fc41.x86_64.rpm deepin-util-dfm-1.2.23-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppaofgqu0')] checks: 32, packages: 9 deepin-util-dfm.src: E: spelling-error ('libdfm', '%description -l en_US libdfm -> libido') dfm-burn-devel.x86_64: W: no-documentation dfm-io-devel.x86_64: W: no-documentation dfm-mount-devel.x86_64: W: no-documentation dfm-burn.x86_64: W: name-repeated-in-summary dfm-burn dfm-io.x86_64: W: name-repeated-in-summary dfm-io dfm-mount.x86_64: W: name-repeated-in-summary dfm-mount 9 packages and 0 specfiles checked; 1 errors, 6 warnings, 71 filtered, 1 badness; has taken 1.1 s Rpmlint (debuginfo) ------------------- Checking: deepin-util-dfm-debuginfo-1.2.23-1.fc41.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7lxb3llv')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "dfm-mount". (none): E: there is no installed rpm "dfm-io-devel". (none): E: there is no installed rpm "dfm-mount-devel". (none): E: there is no installed rpm "deepin-util-dfm-debuginfo". (none): E: there is no installed rpm "dfm-io". (none): E: there is no installed rpm "dfm-burn-devel". (none): E: there is no installed rpm "dfm-burn". (none): E: there is no installed rpm "deepin-util-dfm-debugsource". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 8 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/linuxdeepin/util-dfm/archive/1.2.23/util-dfm-1.2.23.tar.gz : CHECKSUM(SHA256) this package : 4ceca024dd6cce56a1237ffb4e298d43f3079f84e24016f4cf523f3b6e2f006e CHECKSUM(SHA256) upstream package : 4ceca024dd6cce56a1237ffb4e298d43f3079f84e24016f4cf523f3b6e2f006e Requires -------- dfm-burn (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libisoburn.so.1()(64bit) libisoburn.so.1(LIBISOBURN1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) dfm-burn-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) dfm-burn(x86-64) libdfm-burn.so.0()(64bit) pkgconfig(Qt5Core) pkgconfig(libisoburn-1) dfm-io (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libmediainfo.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) dfm-io-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) dfm-io(x86-64) libdfm-io.so.0()(64bit) dfm-mount (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libmount.so.1()(64bit) libmount.so.1(MOUNT_2.19)(64bit) libmount.so.1(MOUNT_2.21)(64bit) libmount.so.1(MOUNT_2.22)(64bit) libmount.so.1(MOUNT_2.25)(64bit) libsecret-1.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libudisks2.so.0()(64bit) rtld(GNU_HASH) dfm-mount-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) dfm-mount(x86-64) libdfm-mount.so.0()(64bit) pkgconfig(gio-2.0) pkgconfig(libsecret-1) pkgconfig(udisks2) deepin-util-dfm-debuginfo (rpmlib, GLIBC filtered): deepin-util-dfm-debugsource (rpmlib, GLIBC filtered): Provides -------- dfm-burn: dfm-burn dfm-burn(x86-64) libdfm-burn.so.0()(64bit) dfm-burn-devel: cmake(dfm-burn) dfm-burn-devel dfm-burn-devel(x86-64) pkgconfig(dfm-burn) dfm-io: dfm-io dfm-io(x86-64) libdfm-io.so.0()(64bit) dfm-io-devel: cmake(dfm-io) dfm-io-devel dfm-io-devel(x86-64) pkgconfig(dfm-io) dfm-mount: dfm-mount dfm-mount(x86-64) libdfm-mount.so.0()(64bit) dfm-mount-devel: cmake(dfm-mount) dfm-mount-devel dfm-mount-devel(x86-64) pkgconfig(dfm-mount) deepin-util-dfm-debuginfo: deepin-util-dfm-debuginfo deepin-util-dfm-debuginfo(x86-64) deepin-util-dfm-debugsource: deepin-util-dfm-debugsource deepin-util-dfm-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name deepin-util-dfm --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Perl, PHP, Ocaml, Haskell, SugarActivity, fonts, Java, R, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-util-dfm
FEDORA-2024-7fffb0413b (deepin-util-dfm-1.2.23-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7fffb0413b
FEDORA-2024-7fffb0413b (deepin-util-dfm-1.2.23-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.