Spec URL: https://download.copr.fedorainfracloud.org/results/lecris/pytest-check/srpm-builds/07410536/python-pytest-check.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lecris/pytest-check/srpm-builds/07410536/python-pytest-check-2.3.1-1.fc39.src.rpm Description: A pytest plugin that allows multiple failures per test. Fedora Account System Username: lecris Also copr project: https://copr.fedorainfracloud.org/coprs/lecris/pytest-check/build/07410536/
Copr build: https://copr.fedorainfracloud.org/coprs/build/7410534 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279108-python-pytest-check/fedora-rawhide-x86_64/07410534-python-pytest-check/fedora-review/review.txt Found issues: - License file LICENSE.txt is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/lecris/pytest-check/srpm-builds/07410536/python-pytest-check.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lecris/pytest-check/srpm-builds/07410536/python-pytest-check-2.3.1-1.fc39.src.rpm
Created attachment 2031356 [details] The .spec file difference from Copr build 7410534 to 7410541
Copr build: https://copr.fedorainfracloud.org/coprs/build/7410541 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279108-python-pytest-check/fedora-rawhide-x86_64/07410541-python-pytest-check/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I will take this review. I know you said the packages I have up for review are too complex, which I understand. This is a freebie.
Remove the period from the end of the Summary field. See the rpmlint summary-ended-with-dot warning below. This package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "*No copyright* MIT License", "Unknown or generated". 68 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2279108-python-pytest- check/licensecheck.txt [x]: Package requires other packages for directories it uses. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 13007 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pytest-check-2.3.1-1.fc41.noarch.rpm python-pytest-check-2.3.1-1.fc41.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnxfzfww9')] checks: 32, packages: 2 python-pytest-check.src: W: summary-ended-with-dot A pytest plugin that allows multiple failures per test. python3-pytest-check.noarch: W: summary-ended-with-dot A pytest plugin that allows multiple failures per test. =========== 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 8 filtered, 0 badness; has taken 0.4 s =========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-pytest-check.noarch: W: summary-ended-with-dot A pytest plugin that allows multiple failures per test. 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 4 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pytest_check/pytest_check-2.3.1.tar.gz : CHECKSUM(SHA256) this package : 51b8f18a8ccaa426c5d913c4e0e46f014aaa7579481ea03d22d7e1f498f689b2 CHECKSUM(SHA256) upstream package : 51b8f18a8ccaa426c5d913c4e0e46f014aaa7579481ea03d22d7e1f498f689b2 Requires -------- python3-pytest-check (rpmlib, GLIBC filtered): python(abi) python3.12dist(pytest) Provides -------- python3-pytest-check: python-pytest-check python3-pytest-check python3.12-pytest-check python3.12dist(pytest-check) python3dist(pytest-check) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2279108 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Perl, Haskell, PHP, C/C++, fonts, Ocaml, SugarActivity, R, Ruby, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://download.copr.fedorainfracloud.org/results/lecris/pytest-check/srpm-builds/07426496/python-pytest-check.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lecris/pytest-check/srpm-builds/07426496/python-pytest-check-2.3.1-1.fc40.src.rpm Cool, updated
I already approved the package, so you can proceed with requesting a repository and building. I just meant you should change Summary before committing.
Thanks, it will take some time for me to remember the review process. I think I remember the steps now, thanks for the review
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-check
FEDORA-2024-3fd5138784 (python-pytest-check-2.3.1-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3fd5138784
FEDORA-2024-3fd5138784 (python-pytest-check-2.3.1-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.