Spec URL: https://music.fedorapeople.org/rust-blosc2-sys.spec SRPM URL: https://music.fedorapeople.org/rust-blosc2-sys-0.2.6-1.fc39.src.rpm Description: Bindings to C Blosc2. Fedora Account System Username: music This is required for a new rust-blosc2-rs package, not yet posted for review (working on a test failure, https://github.com/milesgranger/blosc2-rs/issues/19); that, in turn, will be needed in order to update rust-libcramjam to 0.4.x, bug 2277635, which will be required for the upcoming python-cramjam 2.8.4 release. The only manual change to the output of rust2rpm was removing the two lines for the licenses of the bundled blosc2 and recursively-bundled zlib-ng that we removed in %prep: %license %{crate_instdir}/c-blosc2/LICENSE.txt %license %{crate_instdir}/c-blosc2/internal-complibs/zlib-ng-2.0.7/LICENSE.md
Created attachment 2031653 [details] Configuration file for rust2rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7420417 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279337-rust-blosc2-sys/fedora-rawhide-x86_64/07420417-rust-blosc2-sys/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Since I realized I could use git format-patch --relative to export usable downstream patches from git, I elected to use a patch file for some downstream patches that previously used moderately complicated sed invocations. I re-uploaded using the same URLs: Spec URL: https://music.fedorapeople.org/rust-blosc2-sys.spec SRPM URL: https://music.fedorapeople.org/rust-blosc2-sys-0.2.6-1.fc39.src.rpm
Created attachment 2031730 [details] Updated configuration for rust2rpm
Created attachment 2031731 [details] The .spec file difference from Copr build 7420417 to 7420882
Copr build: https://copr.fedorainfracloud.org/coprs/build/7420882 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279337-rust-blosc2-sys/fedora-rawhide-x86_64/07420882-rust-blosc2-sys/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good in general, some small comments: - Technically, your patch to Cargo.toml drops one implicit-feature-for-optional-dependency ("bindgen"). Nothing should depend on this directly, but you might want to reintroduce an empty "bindgen = []" feature to preserve it. - You are patching build.rs to unconditionally regenerate bindings. The "-f regenerate-bindings" flag in the spec file is redundant, you could drop it.
Thanks! Those are good suggestions. New Spec URL: https://music.fedorapeople.org/20240807/rust-blosc2-sys.spec New SRPM URL: https://music.fedorapeople.org/20240807/rust-blosc2-sys-0.2.6-1.fc40.src.rpm
Created attachment 2043650 [details] Updated configuration for rust2rpm
Sorry for the delay - looks good to me! (haven't tested that the bindings actually work when built this way, but we'll see that soon enough.) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Thank you for the review! I was having some trouble getting the blosc2-rs crate to work correctly on top of this, which I’m not convinced are “my fault” – https://github.com/milesgranger/blosc2-rs/issues/23#issuecomment-2124738480 – but I’ll get that working one way or another before posting rust-blosc2-rs for review. For now, I’ll go ahead and import this. https://release-monitoring.org/project/374058/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-blosc2-sys
FEDORA-2024-966cdd9019 (rust-blosc2-sys-0.2.6-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-966cdd9019
FEDORA-2024-966cdd9019 (rust-blosc2-sys-0.2.6-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-4634f5095d (rust-blosc2-sys-0.2.6-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4634f5095d
FEDORA-2024-0d08196a6b (rust-blosc2-sys-0.2.6-2.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0d08196a6b
FEDORA-2024-472ad2af4c (rust-blosc2-sys-0.2.6-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-472ad2af4c
FEDORA-2024-472ad2af4c has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-472ad2af4c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-472ad2af4c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-0d08196a6b has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0d08196a6b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0d08196a6b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-4634f5095d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4634f5095d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4634f5095d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-0d08196a6b (rust-blosc2-sys-0.2.6-2.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-4634f5095d (rust-blosc2-sys-0.2.6-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-eefba2bed5 (rust-blosc2-sys-0.3.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.