SRPM:https://fedorapeople.org/~limb/review/python-columnar/python-columnar-1.4.1-1.fc41.src.rpm SPEC:https://fedorapeople.org/~limb/review/python-columnar/python-columnar.spec Description: A library for creating columnar output strings using data as input.
There seems to be some problem with the following file. SRPM URL: https://fedorapeople.org/~limb/review/python-columnar/python-columnar-1.4.1-1.fc40.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
SRPM:https://fedorapeople.org/~limb/review/python-columnar/python-columnar-1.4.1-1.fc41.src.rpm SPEC:https://fedorapeople.org/~limb/review/python-columnar/python-columnar.spec
It will not currently build. It appears that the only source is what is on PyPI. To get it to build, consider modifying the spec file. Change Source0: https://files.pythonhosted.org/packages/source/c/%{pypi_name}/Columnar-%{pypi_version}.tar.gz to Source0: %{pypi_source Columnar} Remove BuildRequires: python3dist(setuptools) Remove Requires: python3dist(toolz) Requires: python3dist(wcwidth) see Change %pyproject_buildrequires -t to %pyproject_buildrequires there are no test dependencies Change %pyproject_install to %pyproject_install %pyproject_save_files columnar %check %pyproject_check_import Change %files -n python3-%{pypi_name} %doc README.md %{python3_sitelib}/%{pypi_name} %{python3_sitelib}/Columnar-%{pypi_version}.dist-info/ to %files -n python3-%{pypi_name} -f %{pyproject_files} %doc README.md For a smoke test you might use code from https://pypi.org/project/columnar/ to generate something like cat <<EOF> testfile.py from columnar import columnar headers = ['name', 'id', 'host', 'notes'] data = [ ['busybox', 'c3c37d5d-38d2-409f-8d02-600fd9d51239', 'linuxnode-1-292735', 'Test server.'], ['alpine-python', '6bb77855-0fda-45a9-b553-e19e1a795f1e', 'linuxnode-2-249253', 'The one that runs python.'], ['redis', 'afb648ba-ac97-4fb2-8953-9a5b5f39663e', 'linuxnode-3-3416918', 'For queues and stuff.'], ['app-server', 'b866cd0f-bf80-40c7-84e3-c40891ec68f9', 'linuxnode-4-295918', 'A popular destination.'], ['nginx', '76fea0f0-aa53-4911-b7e4-fae28c2e469b', 'linuxnode-5-292735', 'Traffic Cop'], ] table = columnar(data, headers, no_borders=True) print(table) EOF Then in the %check section add %py3_test_envvars %python3 testfile.py
Thank you, that was helpful. SRPM:https://fedorapeople.org/~limb/review/python-columnar/python-columnar-1.4.1-2.fc43.src.rpm SPEC:https://fedorapeople.org/~limb/review/python-columnar/python-columnar.spec
Copr build: https://copr.fedorainfracloud.org/coprs/build/9064029 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279794-python-columnar/fedora-rawhide-x86_64/09064029-python-columnar/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* MIT License", "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-columnar/2279794-python- columnar/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13, /usr/lib/python3.13/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 11020 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-columnar-1.4.1-2.fc43.noarch.rpm python-columnar-1.4.1-2.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa2vihx5i')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/C/Columnar/Columnar-1.4.1.tar.gz : CHECKSUM(SHA256) this package : c3cb57273333b2ff9cfaafc86f09307419330c97faa88dcfe23df05e6fbb9c72 CHECKSUM(SHA256) upstream package : c3cb57273333b2ff9cfaafc86f09307419330c97faa88dcfe23df05e6fbb9c72 Requires -------- python3-columnar (rpmlib, GLIBC filtered): python(abi) python3.13dist(toolz) python3.13dist(wcwidth) Provides -------- python3-columnar: python-columnar python3-columnar python3.13-columnar python3.13dist(columnar) python3dist(columnar) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2279794 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Java, R, Ocaml, Haskell, fonts, C/C++, Perl, SugarActivity, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please contact upstream and see if they can add a license file b) Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=133004946 c) Approved d) Review of one of: https://bugzilla.redhat.com/show_bug.cgi?id=2362757 https://bugzilla.redhat.com/show_bug.cgi?id=2361707 would be appreciated if time allows.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-columnar
Thank you!
FEDORA-2025-812b9db95d (python-columnar-1.4.1-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-812b9db95d
FEDORA-2025-812b9db95d has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-812b9db95d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-812b9db95d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-812b9db95d (python-columnar-1.4.1-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.