Bug 2279916 - Review Request: rust-lalr - Library for creating LALR(1) parsers from context-free grammars
Summary: Review Request: rust-lalr - Library for creating LALR(1) parsers from context...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/lalr
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-09 19:42 UTC by wojnilowicz
Modified: 2024-05-17 15:57 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-05-17 15:53:15 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description wojnilowicz 2024-05-09 19:42:12 UTC
Spec URL: https://wojnilowicz.fedorapeople.org/rust-lalr.spec
SRPM URL: https://wojnilowicz.fedorapeople.org/rust-lalr-0.0.2-1.fc39.src.rpm

Description:
A library for creating LALR(1) parsers from context-free grammars.

Fedora Account System Username: wojnilowicz

It's in the dependency chain for building https://github.com/ActivityWatch/activitywatch (lalr->plex->aw-server-rust specifically)

One can see that it's working at https://copr.fedorainfracloud.org/coprs/wojnilowicz/activitywatch/

Comment 1 Fedora Review Service 2024-05-09 19:42:44 UTC
There seems to be some problem with the following file.
SRPM URL: https://wojnilowicz.fedorapeople.org/rust-lalr-0.0.2-1.fc39.src.rpm
Fetching it results in a 403 Forbidden error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 wojnilowicz 2024-05-11 12:53:43 UTC
[fedora-review-service-build]

Comment 3 wojnilowicz 2024-05-11 17:26:44 UTC
[fedora-review-service-build]

Comment 5 Fedora Review Service 2024-05-11 20:28:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7436009
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279916-rust-lalr/fedora-rawhide-x86_64/07436009-rust-lalr/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2024-05-11 20:28:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7436011
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279916-rust-lalr/fedora-rawhide-x86_64/07436011-rust-lalr/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fedora Review Service 2024-05-11 20:28:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7436006
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279916-rust-lalr/fedora-rawhide-x86_64/07436006-rust-lalr/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fabio Valentini 2024-05-17 13:55:09 UTC
This crate hasn't been updated in 8 years :(

The package looks good, but maybe plex should move to a different (maintained!) parser generator in the medium-to-long-term.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 9 Fedora Admin user for bugzilla script actions 2024-05-17 15:33:18 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lalr

Comment 10 Fedora Update System 2024-05-17 15:48:34 UTC
FEDORA-2024-864397a00a (rust-lalr-0.0.2-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-864397a00a

Comment 11 Fedora Update System 2024-05-17 15:53:15 UTC
FEDORA-2024-864397a00a (rust-lalr-0.0.2-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 wojnilowicz 2024-05-17 15:57:00 UTC
(In reply to Fabio Valentini from comment #8)
> This crate hasn't been updated in 8 years :(
> 
> The package looks good, but maybe plex should move to a different
> (maintained!) parser generator in the medium-to-long-term.

Thanks! I've done everything.

As for the maintained package then it's unlikely to happen, because lalr and plex have the same author. Plex exhibits more life though, as it was updated 7 months ago.


Note You need to log in before you can comment on or make changes to this bug.