Bug 2280091 - vlc lua http media info and playing state does not update on web
Summary: vlc lua http media info and playing state does not update on web
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: vlc
Version: 40
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Yaakov Selkowitz
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-11 14:58 UTC by Martin
Modified: 2024-06-15 04:45 UTC (History)
3 users (show)

Fixed In Version: vlc-3.0.20-15.fc40 vlc-3.0.21-1.fc39
Clone Of:
Environment:
Last Closed: 2024-06-05 01:40:54 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to resolve use of deprecated POW function. Fixes lua web interface. (457 bytes, patch)
2024-06-01 22:25 UTC, Christopher X. Candreva
no flags Details | Diff

Description Martin 2024-05-11 14:58:17 UTC
VLC 3.0.20-12

If using http lua to control vlc while running, you no longer get media info, playlist or state of media. Control still work, but e.g. play icon does not toggle between play and pause symbol.

I used to run FC39 with 3.0.19 from RPMfusion, where this was not an issue.
When properly configured it worked out of the box. This does not seem to be the case with packages in Fedora repo.

Since updating to FC40, RPMfusion no longer have packages for my install.


Reproducible: Always

Steps to Reproduce:
1.Start vlc with lua http
2.Play media
3.Login to http
4.Observe details about media files, and compare to vlc main interface
Actual Results:  
Cannot see info about media files, or progress.

Expected Results:  
Too see info about media files and progress.

Comment 1 Christopher X. Candreva 2024-06-01 22:24:31 UTC
There is an actual error returned concerning the **pow** function. 
VLC assumes lua is compiled with legacy functions enabled. The lua shipped with recent Fedora versions evidently has these turned off.
I will attach a patch **share/lua/intf/modules/httprequests.lua** that resolves the issue by removing the call to the deprecated POW function.

Comment 2 Christopher X. Candreva 2024-06-01 22:25:52 UTC
Created attachment 2036049 [details]
Patch to resolve use of deprecated POW function. Fixes lua web interface.

Comment 3 Dominik 'Rathann' Mierzejewski 2024-06-02 17:10:32 UTC
Great catch, Christopher, thanks!

LUA upstream reference:
https://www.lua.org/manual/5.3/manual.html#8.2
...
The following functions were deprecated in the mathematical library: atan2, cosh, sinh, tanh, pow, frexp, and ldexp. You can replace math.pow(x,y) with x^y; you can replace math.atan2 with math.atan, which now accepts one or two arguments; you can replace math.ldexp(x,exp) with x * 2.0^exp. For the other operations, you can either use an external library or implement them in Lua.

Comment 4 Martin 2024-06-02 18:26:38 UTC
Thank you Christopher

I have managed to fixed my vlc by replacing httprequests.luac updated with your patch.
Hopefully, the patch will also be merged in an upcoming vlc package update.

Comment 5 Fedora Update System 2024-06-03 04:10:22 UTC
FEDORA-2024-7061536821 (vlc-3.0.20-15.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7061536821

Comment 6 Fedora Update System 2024-06-03 05:10:31 UTC
FEDORA-2024-1303bd4ec0 (vlc-3.0.20-15.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1303bd4ec0

Comment 7 Fedora Update System 2024-06-04 01:06:20 UTC
FEDORA-2024-7061536821 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7061536821`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7061536821

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-06-04 03:44:37 UTC
FEDORA-2024-1303bd4ec0 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1303bd4ec0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1303bd4ec0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Christopher X. Candreva 2024-06-04 14:01:09 UTC
I've installed the version from Fedora 40 updates-testing on my system and confirm it is working as expected.

Comment 10 Fedora Update System 2024-06-05 01:40:54 UTC
FEDORA-2024-1303bd4ec0 (vlc-3.0.20-15.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2024-06-07 01:52:03 UTC
FEDORA-2024-a03c4ba298 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a03c4ba298`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a03c4ba298

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-06-15 04:45:19 UTC
FEDORA-2024-a03c4ba298 (vlc-3.0.21-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.