Bug 2280801 - Review Request: rust-ego-tree - Vec-backed ID-tree
Summary: Review Request: rust-ego-tree - Vec-backed ID-tree
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/ego-tree
Whiteboard:
Depends On:
Blocks: 2280802
TreeView+ depends on / blocked
 
Reported: 2024-05-16 10:23 UTC by Gustavo Costa
Modified: 2024-06-08 22:42 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-08 22:38:23 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Gustavo Costa 2024-05-16 10:23:39 UTC
Spec URL: https://xfgusta.fedorapeople.org/pkgs/rust-ego-tree.spec
SRPM URL: https://xfgusta.fedorapeople.org/pkgs/rust-ego-tree-0.6.2-1.fc41.src.rpm

Description:
Vec-backed ID-tree

Fedora Account System Username: xfgusta

Comment 1 Fedora Review Service 2024-05-16 11:18:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7449614
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2280801-rust-ego-tree/fedora-rawhide-x86_64/07449614-rust-ego-tree/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-06-03 11:33:17 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

If you have the time, it would be great if you could review one of my pending packages in return (for example, #2283299).

Comment 3 Fedora Admin user for bugzilla script actions 2024-06-08 22:09:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ego-tree

Comment 4 Fedora Update System 2024-06-08 22:34:13 UTC
FEDORA-2024-f4a878233b (rust-ego-tree-0.6.2-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f4a878233b

Comment 5 Fedora Update System 2024-06-08 22:38:23 UTC
FEDORA-2024-f4a878233b (rust-ego-tree-0.6.2-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Gustavo Costa 2024-06-08 22:42:42 UTC
Thank you for the review!

> If you have the time, it would be great if you could review one of my pending packages in return (for example, #2283299).

Sure, no problem. This one has already been reviewed, but I'll take a look at the others


Note You need to log in before you can comment on or make changes to this bug.