Bug 2281490 - Review Request: rust-lockfree-object-pool - Thread-safe object pool with automatic return and attach/detach semantics
Summary: Review Request: rust-lockfree-object-pool - Thread-safe object pool with auto...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2281428
TreeView+ depends on / blocked
 
Reported: 2024-05-19 13:25 UTC by Ben Beasley
Modified: 2024-05-21 15:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-05-21 15:11:13 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (458 bytes, text/plain)
2024-05-19 13:42 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2024-05-19 13:25:42 UTC
Spec URL: https://music.fedoraproject.org/rust-lockfree-object-pool.spec
SRPM URL: https://music.fedoraproject.org/rust-lockfree-object-pool-0.1.5-1.fc39.src.rpm

Description:

A thread-safe object pool collection with automatic return and
attach/detach semantics.

Fedora Account System Username: music

This package built in koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=117899978

Comment 1 Ben Beasley 2024-05-19 13:42:19 UTC
Upstream already followed up to my request to exclude benchmark reports from the published crate, so here is a new release:

New Spec URL: https://music.fedoraproject.org/20240519/rust-lockfree-object-pool.spec
New SRPM URL: https://music.fedoraproject.org/20240519/rust-lockfree-object-pool-0.1.6-1.fc39.src.rpm

Comment 2 Ben Beasley 2024-05-19 13:42:54 UTC
Created attachment 2033969 [details]
Configuration file for rust2rpm

Comment 3 Fabio Valentini 2024-05-20 18:33:49 UTC
Should those URLs point at fedorapeople.org instead of fedoraproject.org?

Comment 4 Ben Beasley 2024-05-20 18:56:04 UTC
(In reply to Fabio Valentini from comment #3)
> Should those URLs point at fedorapeople.org instead of fedoraproject.org?

Yes, thanks.

New Spec URL: https://music.fedorapeople.org/20240519/rust-lockfree-object-pool.spec
New SRPM URL: https://music.fedorapeople.org/20240519/rust-lockfree-object-pool-0.1.6-1.fc39.src.rpm

Comment 5 Fabio Valentini 2024-05-20 19:57:53 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Ben Beasley 2024-05-21 14:00:24 UTC
Thank you for the review!

Comment 7 Fedora Admin user for bugzilla script actions 2024-05-21 14:00:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lockfree-object-pool

Comment 8 Ben Beasley 2024-05-21 14:12:00 UTC
https://release-monitoring.org/project/372453/

Comment 9 Fedora Update System 2024-05-21 14:15:33 UTC
FEDORA-2024-90a19b6e40 (rust-lockfree-object-pool-0.1.6-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-90a19b6e40

Comment 10 Fedora Update System 2024-05-21 15:11:13 UTC
FEDORA-2024-90a19b6e40 (rust-lockfree-object-pool-0.1.6-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.