Bug 2281494 - Review Request: rust-rust-netrc - Netrc support for Rust with support for reqwest
Summary: Review Request: rust-rust-netrc - Netrc support for Rust with support for req...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/rust-netrc
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-19 14:34 UTC by Ben Beasley
Modified: 2024-06-02 03:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-05-24 17:56:20 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2024-05-19 14:34:05 UTC
Spec URL: https://music.fedoraproject.org/rust-rust-netrc.spec
SRPM URL: https://music.fedoraproject.org/rust-rust-netrc-0.1.1-1.fc39.src.rpm

Description:

Netrc support for Rust with support for reqwest.

Fedora Account System Username: music

This package built in koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=117901539

This is a dependency for a future package of https://pypi.org/project/uv.

The spec file is exactly as produced by rust2rpm, with no rust2rpm.toml.

https://release-monitoring.org/project/372434/

Comment 2 Fedora Review Service 2024-05-19 19:49:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7461866
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2281494-rust-rust-netrc/fedora-rawhide-x86_64/07461866-rust-rust-netrc/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2024-05-24 14:08:18 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Ben Beasley 2024-05-24 14:11:40 UTC
Thank you for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2024-05-24 14:12:18 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rust-netrc

Comment 6 Fedora Update System 2024-05-24 17:51:20 UTC
FEDORA-2024-250efcd2b0 (rust-rust-netrc-0.1.1-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-250efcd2b0

Comment 7 Fedora Update System 2024-05-24 17:56:20 UTC
FEDORA-2024-250efcd2b0 (rust-rust-netrc-0.1.1-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-05-24 18:05:21 UTC
FEDORA-2024-7f0deb7ad4 (rust-rust-netrc-0.1.1-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f0deb7ad4

Comment 9 Fedora Update System 2024-05-24 18:30:37 UTC
FEDORA-2024-492e7d1669 (rust-rust-netrc-0.1.1-2.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-492e7d1669

Comment 10 Fedora Update System 2024-05-25 01:48:53 UTC
FEDORA-2024-492e7d1669 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-492e7d1669 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-492e7d1669

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-05-25 01:57:09 UTC
FEDORA-2024-7f0deb7ad4 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7f0deb7ad4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f0deb7ad4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-06-02 01:22:09 UTC
FEDORA-2024-7f0deb7ad4 (rust-rust-netrc-0.1.1-2.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-06-02 03:37:46 UTC
FEDORA-2024-492e7d1669 (rust-rust-netrc-0.1.1-2.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.