Spec URL: https://yselkowitz.fedorapeople.org/kalm.spec SRPM URL: https://yselkowitz.fedorapeople.org/kalm-24.04.90-1.fc41.src.rpm Description: Kalm can teach you different breathing techniques. Fedora Account System Username: yselkowitz
Copr build: https://copr.fedorainfracloud.org/coprs/build/7461871 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2281543-kalm/fedora-rawhide-x86_64/07461871-kalm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Two suggestions, one mandatory and one superficial: 1- (Mandatory) You're missing licenses in there, according to reuse: * Used licenses: BSD-2-Clause, CC-BY-SA-4.0, CC0-1.0, LGPL-2.1-or-later (Those licenses are also in the project's LICENSES folder) 2- (Superficial) I think your e-mail is mistyped in the clog :)
(In reply to Steve Cossette from comment #2) > Two suggestions, one mandatory and one superficial: > > 1- (Mandatory) You're missing licenses in there, according to reuse: > > * Used licenses: BSD-2-Clause, CC-BY-SA-4.0, CC0-1.0, LGPL-2.1-or-later > (Those licenses are also in the project's LICENSES folder) > > 2- (Superficial) I think your e-mail is mistyped in the clog :) Nevermind #2 :)
(In reply to Steve Cossette from comment #2) > 1- (Mandatory) You're missing licenses in there, according to reuse: > > * Used licenses: BSD-2-Clause, CC-BY-SA-4.0, CC0-1.0, LGPL-2.1-or-later > (Those licenses are also in the project's LICENSES folder) Files that are used only for CI and/or build infrastructure are not installed and therefore their licenses need not be included.
Spec URL: https://yselkowitz.fedorapeople.org/kalm.spec SRPM URL: https://yselkowitz.fedorapeople.org/kalm-24.05.0-1.fc41.src.rpm Description: Kalm can teach you different breathing techniques. Fedora Account System Username: yselkowitz
Created attachment 2034992 [details] The .spec file difference from Copr build 7461871 to 7486931
Copr build: https://copr.fedorainfracloud.org/coprs/build/7486931 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2281543-kalm/fedora-rawhide-x86_64/07486931-kalm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled and recorded * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/kalm