Spec URL: https://gui1ty.fedorapeople.org/review/python-pyftpdlib.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-pyftpdlib-1.5.9-1.src.rpm Description: Python FTP server library provides a high-level portable interface to easily write very efficient, scalable and asynchronous FTP servers with Python. It is the most complete RFC-959 FTP server implementation available for Python programming language. Fedora Account System Username: gui1ty
Copr build: https://copr.fedorainfracloud.org/coprs/build/7475808 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282430-python-pyftpdlib/fedora-rawhide-x86_64/07475808-python-pyftpdlib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://gui1ty.fedorapeople.org/review/python-pyftpdlib.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-pyftpdlib-1.5.9-1.20240522gitrelease.1.5.9.fc41.src.rpm
I tried to avoid the annoying long version suffix. But no luck. Using `%autorelease -n` results in `%{?dist}` being dropped as well, breaking the package.
Created attachment 2034601 [details] The .spec file difference from Copr build 7475808 to 7476076
Copr build: https://copr.fedorainfracloud.org/coprs/build/7476076 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282430-python-pyftpdlib/fedora-rawhide-x86_64/07476076-python-pyftpdlib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://gui1ty.fedorapeople.org/review/python-pyftpdlib.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-pyftpdlib-1.5.9-1.fc41.src.rpm
(In reply to Sandro from comment #3) > I tried to avoid the annoying long version suffix. But no luck. Using > `%autorelease -n` results in `%{?dist}` being dropped as well, breaking the > package. Fixed with `%global distprefix %{nil}`.
Created attachment 2034679 [details] The .spec file difference from Copr build 7476076 to 7477658
Copr build: https://copr.fedorainfracloud.org/coprs/build/7477658 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282430-python-pyftpdlib/fedora-rawhide-x86_64/07477658-python-pyftpdlib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
It looks like this doesn’t quite build in Rawhide anymore: ==================================== ERRORS ==================================== __________ ERROR at teardown of TestFtpListingCmdsTLSMixin.test_nlst ___________ pyftpdlib/test/test_functional.py:1115: in tearDown close_client(self.client) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ session = <pyftpdlib.test.test_functional_ssl.FTPSClient object at 0x7fb4f050b540> def close_client(session): """Closes a ftplib.FTP client session.""" try: if session.sock is not None: try: resp = session.quit() except Exception: # noqa pass else: # ...just to make sure the server isn't replying to some # pending command. > assert resp.startswith('221'), resp E AssertionError: 226 Transfer complete. pyftpdlib/test/__init__.py:136: AssertionError =================================== FAILURES =================================== ________________ TestCallbacks.test_on_incomplete_file_received ________________ self = <pyftpdlib.test.test_functional.TestCallbacks testMethod=test_on_incomplete_file_received> @retry_on_failure() def test_on_incomplete_file_received(self): self.client.login(USER, PASSWD) data = b'abcde12345' * 1000000 dummyfile = BytesIO() dummyfile.write(data) dummyfile.seek(0) with contextlib.closing( self.client.transfercmd('stor ' + self.testfn2)) as conn: bytes_sent = 0 while True: chunk = dummyfile.read(BUFSIZE) conn.sendall(chunk) bytes_sent += len(chunk) # stop transfer while it isn't finished yet if bytes_sent >= INTERRUPTED_TRANSF_SIZE or not chunk: self.client.putcmd('abor') break # If a data transfer is in progress server is supposed to send # a 426 reply followed by a 226 reply. > self.assertRaises(ftplib.error_temp, self.client.getresp) # 426 E AssertionError: error_temp not raised by getresp pyftpdlib/test/test_functional.py:1927: AssertionError ----------------------------- Captured stderr call ----------------------------- AssertionError('error_temp not raised by getresp'), retrying AssertionError('error_temp not raised by getresp'), retrying AssertionError('error_temp not raised by getresp'), retrying AssertionError('error_temp not raised by getresp'), retrying AssertionError('error_temp not raised by getresp'), retrying _____________________ TestFtpListingCmdsTLSMixin.test_nlst _____________________ self = <pyftpdlib.test.test_functional_ssl.TestFtpListingCmdsTLSMixin testMethod=test_nlst> @unittest.skipIf(CI_TESTING, "may fail on CI") def test_nlst(self): > super().test_nlst() pyftpdlib/test/test_functional_ssl.py:129: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ pyftpdlib/test/test_functional.py:1149: in test_nlst self._test_listing_cmds('nlst') pyftpdlib/test/test_functional.py:1142: in _test_listing_cmds self.client.retrlines('%s %s' % (cmd, tempdir), x.append) /usr/lib64/python3.13/ftplib.py:476: in retrlines conn.unwrap() _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <ssl.SSLSocket [closed] fd=-1, family=2, type=1, proto=6> @_sslcopydoc def unwrap(self): if self._sslobj: > s = self._sslobj.shutdown() E ssl.SSLError: [SSL: SHUTDOWN_WHILE_IN_INIT] shutdown while in init (_ssl.c:2706) /usr/lib64/python3.13/ssl.py:1339: SSLError =============================== warnings summary =============================== pyftpdlib/test/test_functional_ssl.py::TestFtpListingCmdsTLSMixin::test_stat /builddir/build/BUILD/python-pyftpdlib-1.5.9-build/pyftpdlib-release-1.5.9/pyftpdlib/test/__init__.py:503: UserWarning: some children didn't terminate "[psutil.Process(pid=710, name='pytest', status='sleeping', started='12:57:18')]" assert_free_resources() pyftpdlib/test/test_ioloop.py::DefaultIOLoopTestCase::test_register /usr/lib64/python3.13/unittest/case.py:707: DeprecationWarning: It is deprecated to return a value that is not None from a test case (<bound method BaseIOLoopTestCase.test_register of <pyftpdlib.test.test_ioloop.DefaultIOLoopTestCase testMethod=test_register>>) return self.run(*args, **kwds) pyftpdlib/test/test_ioloop.py::SelectIOLoopTestCase::test_register /usr/lib64/python3.13/unittest/case.py:707: DeprecationWarning: It is deprecated to return a value that is not None from a test case (<bound method BaseIOLoopTestCase.test_register of <pyftpdlib.test.test_ioloop.SelectIOLoopTestCase testMethod=test_register>>) return self.run(*args, **kwds) pyftpdlib/test/test_ioloop.py::PollIOLoopTestCase::test_register /usr/lib64/python3.13/unittest/case.py:707: DeprecationWarning: It is deprecated to return a value that is not None from a test case (<bound method BaseIOLoopTestCase.test_register of <pyftpdlib.test.test_ioloop.PollIOLoopTestCase testMethod=test_register>>) return self.run(*args, **kwds) pyftpdlib/test/test_ioloop.py::EpollIOLoopTestCase::test_register /usr/lib64/python3.13/unittest/case.py:707: DeprecationWarning: It is deprecated to return a value that is not None from a test case (<bound method BaseIOLoopTestCase.test_register of <pyftpdlib.test.test_ioloop.EpollIOLoopTestCase testMethod=test_register>>) return self.run(*args, **kwds) pyftpdlib/test/test_servers.py::TestFtpFsOperationsThreadMixin::test_invalid_mfmt_timeval pyftpdlib/test/test_servers.py::TestFtpFsOperationsThreadMixin::test_mfmt /builddir/build/BUILD/python-pyftpdlib-1.5.9-build/pyftpdlib-release-1.5.9/pyftpdlib/handlers.py:2741: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC). epoch = datetime.utcfromtimestamp(0) pyftpdlib/test/test_servers.py: 90 warnings /usr/lib64/python3.13/multiprocessing/popen_fork.py:67: DeprecationWarning: This process (pid=368) is multi-threaded, use of fork() may lead to deadlocks in the child. self.pid = os.fork() -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html =========================== short test summary info ============================ FAILED pyftpdlib/test/test_functional.py::TestCallbacks::test_on_incomplete_file_received FAILED pyftpdlib/test/test_functional_ssl.py::TestFtpListingCmdsTLSMixin::test_nlst ERROR pyftpdlib/test/test_functional_ssl.py::TestFtpListingCmdsTLSMixin::test_nlst = 2 failed, 731 passed, 55 skipped, 7 deselected, 97 warnings, 1 error in 30.81s =
That's unfortunate. Could this be a flaky test or an arch specific issue? Because locally on x86_64 it succeeds with: fedpkg --release rawhide mockbuild --no-cleanup-after -- --config-opts mirrored=false
(In reply to Sandro from comment #11) > That's unfortunate. Could this be a flaky test or an arch specific issue? > Because locally on x86_64 it succeeds with: > > fedpkg --release rawhide mockbuild --no-cleanup-after -- --config-opts > mirrored=false I can try it again. I simply ran: fedora-review -b 2282430 on x86_64.
This might be a Copr specific issue, because in Koji on aarch64 my scratch build succeeded as well: https://koji.fedoraproject.org/koji/taskinfo?taskID=119910555
Just disregard my last remark. With `fedora-review -b` the build will be run in mock locally. Nonetheless, with fedpkg and koji builds succeeding this smells like something is off with the way fedora-review builds the package.
$ koji build --scratch rawhide ./srpm/python-pyftpdlib-1.5.9-1.fc41.src.rpm --arch-override='x86_64' https://koji.fedoraproject.org/koji/taskinfo?taskID=119910715 That worked at least once.
> fedora-review -b 2282430 This worked on the second try, too. So maybe the tests are flaky, and the package can be reviewed with the understanding that flakiness is Your Problem. ;-)
It should be noted that until recently, this was packaged as https://src.fedoraproject.org/rpms/pyftpdlib; the last state before retirement was https://src.fedoraproject.org/rpms/pyftpdlib/tree/599181d062a49409157462583633f6a41846d19f. I agree that, considering https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_naming, creating a new python-pyftpdlib package is better than unretiring the pyftpdlib.
The package bundles asyncore and asynchat from the Python standard library (up to 3.11; they were removed in Python 3.12). The bundling should be indicated, and the licenses of these files need to be identified and incorporated in the license expression: # ====================================================================== # Copyright 1996 by Sam Rushing # # All Rights Reserved # # Permission to use, copy, modify, and distribute this software and # its documentation for any purpose and without fee is hereby # granted, provided that the above copyright notice appear in all # copies and that both that copyright notice and this permission # notice appear in supporting documentation, and that the name of Sam # Rushing not be used in advertising or publicity pertaining to # distribution of the software without specific, written prior # permission. # # SAM RUSHING DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE, # INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN # NO EVENT SHALL SAM RUSHING BE LIABLE FOR ANY SPECIAL, INDIRECT OR # CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS # OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, # NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN # CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. # ======================================================================
I reworked the package: - Update to 1.5.10 (latest upstream release) - Package the `ssl` extra (obsoletes the `pyopenssl` BR) - Unbundle `asyncore` and `asynchat` in favor of `pyasyncore` and `pyasynchat` (proposed upstream) The latter kills two birds with one stone: bundling and licensing. Spec URL: https://gui1ty.fedorapeople.org/review/python-pyftpdlib.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-pyftpdlib-1.5.10-2.fc41.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7700254 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282430-python-pyftpdlib/fedora-rawhide-x86_64/07700254-python-pyftpdlib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This looks pretty good now! There is an unused BuildRequires that it would be nice to drop, but the package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - This is unused (it appears in a dependency list in the Makefile, but isn’t *actually* used), and should therefore be removed: BuildRequires: python3dist(pytest-xdist) ===== Notes ===== - I wonder if the ftpbench script, https://github.com/giampaolo/pyftpdlib/blob/master/scripts/ftpbench, is worth packaging system-wide like this or not. On one hand, it’s just a benchmarking script, and it doesn’t even use pyftpdlib. On the other hand, it does seem to be a generally useful FTP benchmarking script, as evidenced by its re-use in https://github.com/aio-libs/aioftp/blob/master/ftpbench.py. The only other contender for the name is https://github.com/selectel/ftpbench, which looks pretty obscure. I’m inclined to say that packaging it is fine, and there is probably no one right answer. - I would have added a spec-file comment explaining how the downstream keycert.pem file was generated, but this isn’t mandatory. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 41 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2282430-python-pyftpdlib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. $ rpm -qL -p results/python3-pyftpdlib-1.5.10-2.fc41.noarch.rpm /usr/lib/python3.13/site-packages/pyftpdlib-1.5.10.dist-info/LICENSE [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 48777 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pyftpdlib , python3-pyftpdlib+ssl [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=120739187 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) Differences are solely due to expansion of rpmautospec macros. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). All messages are spurious, either spelling errors that are not real errors, or due to rpmlint not understanding the forge macros. Rpmlint ------- Checking: python3-pyftpdlib-1.5.10-2.fc41.noarch.rpm python3-pyftpdlib+ssl-1.5.10-2.fc41.noarch.rpm python-pyftpdlib-1.5.10-2.fc41.src.rpm ============================================================================================ rpmlint session starts ============================================================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprdk3bq_s')] checks: 32, packages: 3 python-pyftpdlib.src: E: spelling-error ('sendfile', '%description -l en_US sendfile -> send file, send-file, senile') python-pyftpdlib.src: E: spelling-error ('epoll', '%description -l en_US epoll -> poll, e poll') python-pyftpdlib.src: E: spelling-error ('kqueue', '%description -l en_US kqueue -> queue, k queue') python-pyftpdlib.src: E: spelling-error ('authorizers', '%description -l en_US authorizers -> authorizes, authorize rs, authorize-rs') python-pyftpdlib.src: E: spelling-error ('vsftpd', '%description -l en_US vsftpd ') python-pyftpdlib.src: E: spelling-error ('proftpd', '%description -l en_US proftpd -> profit') python3-pyftpdlib+ssl.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-pyftpdlib+ssl.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-pyftpdlib.noarch: E: spelling-error ('sendfile', '%description -l en_US sendfile -> send file, send-file, senile') python3-pyftpdlib.noarch: E: spelling-error ('epoll', '%description -l en_US epoll -> poll, e poll') python3-pyftpdlib.noarch: E: spelling-error ('kqueue', '%description -l en_US kqueue -> queue, k queue') python3-pyftpdlib.noarch: E: spelling-error ('authorizers', '%description -l en_US authorizers -> authorizes, authorize rs, authorize-rs') python3-pyftpdlib.noarch: E: spelling-error ('vsftpd', '%description -l en_US vsftpd ') python3-pyftpdlib.noarch: E: spelling-error ('proftpd', '%description -l en_US proftpd -> profit') python-pyftpdlib.spec: W: patch-not-applied Patch0: unbundle_asyncore_and_asynchat.patch python3-pyftpdlib+ssl.noarch: W: no-documentation ===================================================== 3 packages and 0 specfiles checked; 14 errors, 2 warnings, 31 filtered, 14 badness; has taken 1.0 s ====================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-pyftpdlib+ssl.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-pyftpdlib+ssl.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-pyftpdlib.noarch: E: spelling-error ('sendfile', '%description -l en_US sendfile -> send file, send-file, senile') python3-pyftpdlib.noarch: E: spelling-error ('epoll', '%description -l en_US epoll -> poll, e poll') python3-pyftpdlib.noarch: E: spelling-error ('kqueue', '%description -l en_US kqueue -> queue, k queue') python3-pyftpdlib.noarch: E: spelling-error ('authorizers', '%description -l en_US authorizers -> authorizes, authorize rs, authorize-rs') python3-pyftpdlib.noarch: E: spelling-error ('vsftpd', '%description -l en_US vsftpd ') python3-pyftpdlib.noarch: E: spelling-error ('proftpd', '%description -l en_US proftpd -> profit') python3-pyftpdlib+ssl.noarch: W: no-documentation 2 packages and 0 specfiles checked; 8 errors, 1 warnings, 24 filtered, 8 badness; has taken 0.3 s Source checksums ---------------- https://github.com/giampaolo/pyftpdlib/archive/release-1.5.10/pyftpdlib-release-1.5.10.tar.gz : CHECKSUM(SHA256) this package : 993a48b652c0a2ab9af898fd3acbe422e8558ba91d1451eec20db2584a0178de CHECKSUM(SHA256) upstream package : 993a48b652c0a2ab9af898fd3acbe422e8558ba91d1451eec20db2584a0178de Requires -------- python3-pyftpdlib (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.13dist(pyasynchat) python3.13dist(pyasyncore) python3-pyftpdlib+ssl (rpmlib, GLIBC filtered): python(abi) python3-pyftpdlib python3.13dist(pyopenssl) Provides -------- python3-pyftpdlib: ftpbench python-pyftpdlib python3-pyftpdlib python3.13-pyftpdlib python3.13dist(pyftpdlib) python3dist(pyftpdlib) python3-pyftpdlib+ssl: python-pyftpdlib+ssl python3-pyftpdlib+ssl python3.13-pyftpdlib+ssl python3.13dist(pyftpdlib[ssl]) python3dist(pyftpdlib[ssl]) Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2282430-python-pyftpdlib/srpm/python-pyftpdlib.spec 2024-07-18 14:15:50.106484389 -0400 +++ /home/ben/fedora/review/2282430-python-pyftpdlib/srpm-unpacked/python-pyftpdlib.spec 2024-07-02 20:00:00.000000000 -0400 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 2; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global pypi_name pyftpdlib @@ -124,3 +134,12 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed Jul 03 2024 Sandro <devel> - 1.5.10-2 +- Package ssl extra + +* Wed Jul 03 2024 Sandro <devel> - 1.5.10-1 +- Update to 1.5.10 + +* Wed May 22 2024 Sandro <devel> - 1.5.9-1 +- Initial package +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2282430 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: Haskell, Java, R, Perl, SugarActivity, fonts, C/C++, Ocaml, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The openvswitch and python-fs packages might be able to enable some additional tests with this packaged.
Thanks for the review! (In reply to Ben Beasley from comment #21) > ===== Issues ===== > > - This is unused (it appears in a dependency list in the Makefile, but isn’t > *actually* used), and should therefore be removed: > > BuildRequires: python3dist(pytest-xdist) Right. It's not used because I failed to setup running tests in parallel. I could have simply used `make test-parallel`. That make target uses `-n auto --dist loadgroup`, which are provided by `pytest-xdist`. I prefer running `pytest` directly, so I'll add those flags upon import. > ===== Notes ===== > > - I wonder if the ftpbench script, > https://github.com/giampaolo/pyftpdlib/blob/master/scripts/ftpbench, is > worth > packaging system-wide like this or not. On one hand, it’s just a > benchmarking > script, and it doesn’t even use pyftpdlib. On the other hand, it does seem > to > be a generally useful FTP benchmarking script, as evidenced by its re-use > in > https://github.com/aio-libs/aioftp/blob/master/ftpbench.py. The only other > contender for the name is https://github.com/selectel/ftpbench, which looks > pretty obscure. > > I’m inclined to say that packaging it is fine, and there is probably no one > right answer. Good catch. I'll leave it in there for now. Should it cause any conflicts, I'm aware and can adjust to solve any potential issues. > - I would have added a spec-file comment explaining how the downstream > keycert.pem file was generated, but this isn’t mandatory. That sounds like a good idea and I should have done that right from the start. Now I will need to scratch my head hard and dig around my browser's history to figure out what the issue was exactly and what guide / hint I followed to solve it. I'll try...
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyftpdlib
(In reply to Sandro from comment #23) > > - I would have added a spec-file comment explaining how the downstream > > keycert.pem file was generated, but this isn’t mandatory. > > That sounds like a good idea and I should have done that right from the > start. Now I will need to scratch my head hard and dig around my browser's > history to figure out what the issue was exactly and what guide / hint I > followed to solve it. I'll try... It turns out this is no longer required. Upstream shipped a re-generated cert in 1.5.10: https://github.com/giampaolo/pyftpdlib/commit/99b055b6e9fcfffccb1e4e7c71cef0ca96f37c3e Thanks for making me poke around and discover that. ;)
FEDORA-2024-bda419c6d9 (python-pyftpdlib-1.5.10-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-bda419c6d9
FEDORA-2024-bda419c6d9 (python-pyftpdlib-1.5.10-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-9c1320cd08 (python-pyftpdlib-1.5.10-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9c1320cd08
FEDORA-2024-2bdd42c0e3 (python-pyftpdlib-1.5.10-2.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2bdd42c0e3
FEDORA-2024-2bdd42c0e3 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2bdd42c0e3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2bdd42c0e3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-9c1320cd08 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9c1320cd08 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9c1320cd08 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-9c1320cd08 (python-pyftpdlib-1.5.10-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-2bdd42c0e3 (python-pyftpdlib-1.5.10-2.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.