Bug 2282804 - Review Request: rust-tracing-journald - Rich journald subscriber for tracing
Summary: Review Request: rust-tracing-journald - Rich journald subscriber for tracing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/tracing-jour...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-23 02:40 UTC by Jose Fernandez
Modified: 2024-06-14 14:32 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-06-04 23:08:22 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Jose Fernandez 2024-05-23 02:40:31 UTC
SPEC URL: https://download.copr.fedorainfracloud.org/results/jfernandez/bpftop/fedora-40-x86_64/07478663-rust-tracing-journald/rust-tracing-journald.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jfernandez/bpftop/fedora-40-x86_64/07478663-rust-tracing-journald/rust-tracing-journald-0.3.0-1.fc40.src.rpm
Description: Rich journald subscriber for tracing
Note: Tests disabled due to the need for a running journald service
Fedora Account System Username: jfernandez

Comment 1 Fedora Review Service 2024-05-23 05:18:45 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2024-05-23 12:05:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7480270
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2282804-rust-tracing-journald/fedora-rawhide-x86_64/07480270-rust-tracing-journald/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 wojnilowicz 2024-05-24 19:07:41 UTC
Hi, would you like to swap for https://bugzilla.redhat.com/show_bug.cgi?id=2283042 ?

Comment 5 Jose Fernandez 2024-05-25 00:16:40 UTC
(In reply to wojnilowicz from comment #4)
> Hi, would you like to swap for
> https://bugzilla.redhat.com/show_bug.cgi?id=2283042 ?

I'm new to this and I'm not sure what you mean by swap.

Comment 6 wojnilowicz 2024-05-25 09:24:03 UTC
Oh, OK. I meant a "review swap" as mentioned at https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_contributor

If you think you can handle it then please review my package. I'll review yours in return then.

Comment 7 Fabio Valentini 2024-05-25 10:22:51 UTC
A review swap can only work if both parties involed are already in the "packager" group (which is not the case here).

Comment 8 wojnilowicz 2024-05-25 11:41:08 UTC
(In reply to Fabio Valentini from comment #7)
> A review swap can only work if both parties involed are already in the
> "packager" group (which is not the case here).

Right. I was about to check that but forgot... Thanks for checking that for me.

BTW, https://bugzilla.redhat.com/show_bug.cgi?id=2276462 got lost or is still on your TODO list?

Comment 9 Fabio Valentini 2024-06-03 11:17:02 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
❌ test suite is run and all unit tests pass (disabled with documented reason)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Let me (or your sponsor) know if you need help with the next steps.

Comment 10 Fedora Update System 2024-06-04 23:06:05 UTC
FEDORA-2024-380b69b787 (rust-tracing-journald-0.3.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-380b69b787

Comment 11 Fedora Update System 2024-06-04 23:08:22 UTC
FEDORA-2024-380b69b787 (rust-tracing-journald-0.3.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fabio Valentini 2024-06-10 19:50:50 UTC
Hey, I noticed that you built rust-tracing-journald for both rawhide, f40, and f39, but didn't submit the f40 and f39 builds to "testing".
Was that intentional or just an oversight?

Comment 13 Jose Fernandez 2024-06-11 00:11:56 UTC
(In reply to Fabio Valentini from comment #12)
> Hey, I noticed that you built rust-tracing-journald for both rawhide, f40,
> and f39, but didn't submit the f40 and f39 builds to "testing".
> Was that intentional or just an oversight?

It was an oversight. Thanks for the heads-up. I believe I submitted f40 and f39 to testing now.

Comment 14 Fabio Valentini 2024-06-14 14:32:30 UTC
Great, thanks! Looks good to me now.


Note You need to log in before you can comment on or make changes to this bug.