Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be unavailable on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 228299 - Review Request: python-metar - Coded METAR weather reports parser for Python
Summary: Review Request: python-metar - Coded METAR weather reports parser for Python
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Xavier Lamien
QA Contact: Fedora Package Reviews List
Depends On:
Blocks: 233598
TreeView+ depends on / blocked
Reported: 2007-02-12 16:09 UTC by Matthias Saou
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-04-03 16:49:39 UTC
Type: ---
lxtnow: fedora-review+
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Matthias Saou 2007-02-12 16:09:21 UTC
Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/python-metar/
SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/python-metar/
Description: Python package that parses coded METAR weather reports.

Comment 1 Matthias Saou 2007-03-01 14:21:40 UTC
Please note that this is a totally trivial package from the packaging point of
view, so it should be really easy and quick to review.

Comment 2 Xavier Lamien 2007-03-23 16:12:27 UTC
it'll done this week-end

Comment 3 Xavier Lamien 2007-03-25 20:26:28 UTC
rpmlint output from rpm built package:

E: python-metar non-executable-script
/usr/lib/python2.4/site-packages/metar/Metar.py 0644
E: python-metar non-executable-script
/usr/lib/python2.4/site-packages/metar/__init__.py 0644

should be fix.

Comment 4 Matthias Saou 2007-03-26 11:19:34 UTC
Very few *.py files under site-packages are executable. I don't know what the
current policy is, nor if rpmlint gets it right. What I do think is that these
files don't need to be executable since they will never be run on there own,
they will always be included.

So in this case, I don't think this needs fixing...

Comment 5 Xavier Lamien 2007-03-26 22:53:35 UTC

if they will never be run, i think you can make rpmlint silent by remove shebang
from theses files.

Comment 6 Matthias Saou 2007-03-27 16:57:13 UTC
Well, if you insist... done in 1.3.0-2.

Comment 7 Xavier Lamien 2007-03-29 18:02:53 UTC
> if you insist... done in 1.3.0-2.



OK - Mock Build on FC-6 and FC-Devel (i386)
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License is MIT
OK - Spec in American English
OK - Spec is legible.
OK - Package has correct buildroot.
OK - BuildRequires isn't redundant.
OK - %build and %install stages is correct and work.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Changelog section is correct.
OK - rpmlint output are silent on RPMs (including sub-package) and SRPM files.


OK - Should function as described.

NO - License file is missing in package.


Comment 8 Matthias Saou 2007-03-30 09:36:30 UTC
From the Review Guidelines :
"MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc."

The package does not contain a file with the license, but the PKG-INFO file
indicates clearly that it is MIT licensed, and the full license is at the bottom
of the included README file.

Also, please set the fedora-review flag to "?" if you are effectively doing a
formal review of this package, thanks!

Comment 9 Xavier Lamien 2007-03-30 12:39:01 UTC

OK - License mixed/included in README file which's included in package.


Comment 10 Matthias Saou 2007-03-30 13:19:22 UTC
New Package CVS Request
Package Name: python-metar
Short Description: Coded METAR weather reports parser for Python
Owners: matthias@rpmforge.net
Branches: devel FC-6 FC-5 EL-5 EL-4 (all current)

Note You need to log in before you can comment on or make changes to this bug.