Red Hat Bugzilla – Bug 228299
Review Request: python-metar - Coded METAR weather reports parser for Python
Last modified: 2007-11-30 17:11:57 EST
Spec URL: http://ftp.es6.freshrpms.net/tmp/extras/python-metar/ SRPM URL: http://ftp.es6.freshrpms.net/tmp/extras/python-metar/ Description: Python package that parses coded METAR weather reports.
Please note that this is a totally trivial package from the packaging point of view, so it should be really easy and quick to review.
it'll done this week-end
rpmlint output from rpm built package: E: python-metar non-executable-script /usr/lib/python2.4/site-packages/metar/Metar.py 0644 E: python-metar non-executable-script /usr/lib/python2.4/site-packages/metar/__init__.py 0644 should be fix.
Very few *.py files under site-packages are executable. I don't know what the current policy is, nor if rpmlint gets it right. What I do think is that these files don't need to be executable since they will never be run on there own, they will always be included. So in this case, I don't think this needs fixing...
well, if they will never be run, i think you can make rpmlint silent by remove shebang from theses files.
Well, if you insist... done in 1.3.0-2.
> if you insist... done in 1.3.0-2. ...^^ Well, OK - Mock Build on FC-6 and FC-Devel (i386) OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License is MIT OK - Spec in American English OK - Spec is legible. OK - Package has correct buildroot. OK - BuildRequires isn't redundant. OK - %build and %install stages is correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Changelog section is correct. OK - rpmlint output are silent on RPMs (including sub-package) and SRPM files. others: OK - Should function as described. NO - License file is missing in package. ----------
From the Review Guidelines : "MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc." The package does not contain a file with the license, but the PKG-INFO file indicates clearly that it is MIT licensed, and the full license is at the bottom of the included README file. Also, please set the fedora-review flag to "?" if you are effectively doing a formal review of this package, thanks!
well, OK - License mixed/included in README file which's included in package. ------------- APPROVED -------------
New Package CVS Request ======================= Package Name: python-metar Short Description: Coded METAR weather reports parser for Python Owners: matthias@rpmforge.net Branches: devel FC-6 FC-5 EL-5 EL-4 (all current) InitialCC: