Bug 2283044 - Review Request: rust-devise_core - Library for devising derives and other procedural macros
Summary: Review Request: rust-devise_core - Library for devising derives and other pro...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/%{crate}
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-05-23 18:28 UTC by wojnilowicz
Modified: 2024-06-04 17:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-04 17:35:23 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description wojnilowicz 2024-05-23 18:28:48 UTC
Spec URL: https://wojnilowicz.fedorapeople.org/rust-devise_core.spec
SRPM URL: https://wojnilowicz.fedorapeople.org/rust-devise_core-0.4.1-1.fc39.src.rpm

Description:
Library for devising derives and other procedural macros

Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and devise_core package is in its requirements chain. The chain is as follows: aw-server-rust->rocket->rocket_codegen->rust-devise->rust-devise_codegen->rust-devise_core.

Comment 1 Fedora Review Service 2024-05-23 18:34:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7482553
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283044-rust-devise_core/fedora-rawhide-x86_64/07482553-rust-devise_core/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-06-04 16:16:02 UTC
Looks good to me.

Note that the guidelines for "Summary" and "%description" are slightly different, which is why rust2rpm adapts the Summary, while it usually takes the description verbatim from the crate metadata. This means that there are almost no cases where you need to adapt the %description.

Please also add a link to the merged upstream PR for adding the license files:
https://github.com/SergioBenitez/Devise/pull/6

===

Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (there are no tests)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files (included from upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-06-04 17:20:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-devise_core

Comment 4 Fedora Update System 2024-06-04 17:31:02 UTC
FEDORA-2024-07e00af10a (rust-devise_core-0.4.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-07e00af10a

Comment 5 Fedora Update System 2024-06-04 17:35:23 UTC
FEDORA-2024-07e00af10a (rust-devise_core-0.4.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 wojnilowicz 2024-06-04 17:37:32 UTC
Thanks. Everything's done.


Note You need to log in before you can comment on or make changes to this bug.