Spec URL: https://decathorpe.fedorapeople.org/rust-terminal-trx.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-terminal-trx-0.2.0-1.fc40.src.rpm Description: Provides a handle to the terminal of the current process. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=118109239
Copr build: https://copr.fedorainfracloud.org/coprs/build/7494021 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283299-rust-terminal-trx/fedora-rawhide-x86_64/07494021-rust-terminal-trx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. ✅ package builds and installs without errors on rawhide 🫤 test suite disabled, but with explanation ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. I believe src/windows{,.rs} isn't needed anymore, so it probably could fall under the "unwanted / unnecessary files" category as described at https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_rust2rpm I'm not sure, if this wouldn't make automation through rust2rpm harder for you, so feel free to keep or remove it. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) ===
Should the __test_unsupported feature be hidden?
Thank you for the review! Yeah, that's probably a good idea. I'll hide that feature.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-terminal-trx
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2024-37582c5cb1