Spec URL: https://wojnilowicz.fedorapeople.org/rust-plex.spec SRPM URL: https://wojnilowicz.fedorapeople.org/rust-plex-0.3.1-1.fc39.src.rpm Description: A syntax extension for writing lexers and parsers. Fedora Account System Username: wojnilowicz
Some minor issues: - If you apply patches to Cargo.toml, please use "rust2rpm -p". It is the only supported mechanism for doing so. - Please add some kind of comment, and if possible, link to upstream commit / PR for the redfa bump.
(In reply to Fabio Valentini from comment #1) > Some minor issues: > > - If you apply patches to Cargo.toml, please use "rust2rpm -p". It is the > only supported mechanism for doing so. Done. > - Please add some kind of comment, and if possible, link to upstream commit > / PR for the redfa bump. I've added a comment explaining why I did so. There is no upstream commit. plex was updated 8 and redfa 6 months ago, so the newer redfa had no chance to be included in the current plex. We could bump the version ourselves as I did or I could request redfa0.0.2 (which is 7 years old) and package it just like the current plex requires. What do you think we should do? [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/7529159 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283517-rust-plex/fedora-rawhide-x86_64/07529159-rust-plex/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> I've added a comment explaining why I did so. There is no upstream commit. plex was updated 8 and redfa 6 months ago, so the newer redfa had no chance to be included in the current plex. Thanks! In that case, it's usually good to submit a pull request to the upstream project. I'll take another look at the package later today. You don't need to NEEDINFO me.
(In reply to Fabio Valentini from comment #4) > > I've added a comment explaining why I did so. There is no upstream commit. plex was updated 8 and redfa 6 months ago, so the newer redfa had no chance to be included in the current plex. > > Thanks! > > In that case, it's usually good to submit a pull request to the upstream > project. FYI, https://github.com/goffrie/plex/pull/56 already got merged and I've updated the spec file. > I'll take another look at the package later today. You don't need to > NEEDINFO me. OK, sorry and thanks.
Great! Looks like upstream already published a new version (0.3.1) that contains the redfa 0.0.2 -> 0.0.3 bump. Can you update the package to the new version? It would allow you to drop the patch entirely.
That's what I did :)
Oh, I didn't notice. Editing comments is ... weird in bugzilla. I'll re-run the review.
Package was generated with rust2rpm, simplifying the review. ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-plex
FEDORA-2024-523210754f (rust-plex-0.3.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-523210754f
FEDORA-2024-523210754f (rust-plex-0.3.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
Thanks for the review.