Bug 2283587 - Review Request: rust-sealed_test_derive - Procmacro attribute to run your test in an isolated environment
Summary: Review Request: rust-sealed_test_derive - Procmacro attribute to run your tes...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2283588
TreeView+ depends on / blocked
 
Reported: 2024-05-28 04:50 UTC by Davide Cavalca
Modified: 2024-06-13 04:05 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-04 20:32:23 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-05-28 04:50:38 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-sealed_test_derive/rust-sealed_test_derive.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sealed_test_derive/rust-sealed_test_derive-1.0.0-1.fc41.src.rpm

Description:
A procmacro attribute to run your test in an isolated environment.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-05-28 04:50:40 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=118190861

Comment 2 Davide Cavalca 2024-05-28 04:51:44 UTC
$ cat rust2rpm.toml 
[package]
extra-sources = [
  { number = 2, file = "https://github.com/oknozor/sealed-test/raw/main/LICENSE", comments = ["https://github.com/oknozor/sealed-test/pull/3"] },
]

[scripts]
prep.pre = ["cp -p %SOURCE2 ."]

Comment 3 Fabio Valentini 2024-06-04 17:17:50 UTC
This project still depends on syn v1, would it be possible to port it to syn v2?
syn v1 has been obsolete for more than a year, and I would rather try to *reduce* the number of packages that depend on the rust-syn1 compat package than *increase* it.

Regardless, package looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files (included from upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2024-06-04 20:13:19 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sealed_test_derive

Comment 5 Fedora Update System 2024-06-04 20:27:33 UTC
FEDORA-2024-534762a908 (rust-sealed_test_derive-1.0.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-534762a908

Comment 6 Fedora Update System 2024-06-04 20:32:23 UTC
FEDORA-2024-534762a908 (rust-sealed_test_derive-1.0.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Davide Cavalca 2024-06-04 20:33:25 UTC
(In reply to Fabio Valentini from comment #3)
> This project still depends on syn v1, would it be possible to port it to syn
> v2?
> syn v1 has been obsolete for more than a year, and I would rather try to
> *reduce* the number of packages that depend on the rust-syn1 compat package
> than *increase* it.

Put up https://github.com/oknozor/sealed-test/pull/4 for that.

Comment 8 Fedora Update System 2024-06-04 20:51:13 UTC
FEDORA-2024-05d502cc58 (rust-sealed_test_derive-1.0.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-05d502cc58

Comment 9 Fedora Update System 2024-06-04 21:03:14 UTC
FEDORA-2024-f0739ab63f (rust-sealed_test_derive-1.0.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f0739ab63f

Comment 10 Fedora Update System 2024-06-05 02:04:01 UTC
FEDORA-2024-05d502cc58 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-05d502cc58 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-05d502cc58

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-06-05 02:29:56 UTC
FEDORA-2024-f0739ab63f has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f0739ab63f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f0739ab63f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-06-13 03:03:22 UTC
FEDORA-2024-f0739ab63f (rust-sealed_test_derive-1.0.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-06-13 04:05:02 UTC
FEDORA-2024-05d502cc58 (rust-sealed_test_derive-1.0.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.