Bug 2283684 - Review Request: rust-average - Calculate statistics iteratively
Summary: Review Request: rust-average - Calculate statistics iteratively
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/average
Whiteboard:
Depends On:
Blocks: 2283679
TreeView+ depends on / blocked
 
Reported: 2024-05-28 19:59 UTC by Cristian Le
Modified: 2024-07-29 10:50 UTC (History)
2 users (show)

Fixed In Version: rust-average-0.15.1-1.fc41
Clone Of:
Environment:
Last Closed: 2024-07-29 10:50:38 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Cristian Le 2024-05-28 19:59:52 UTC
Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/18bb026c3e9d3de4cfbc75fe92babea0b3506a81/rust-average/rust-average.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07500437-rust-average/rust-average-0.15.1-1.fc41.src.rpm
Description: Dependency for `rust-quanta` -> `rust-metrics-exporter-prometheus` -> `atuin`
Fedora Account System Username: lecris

rust2rpm.toml
```toml
[[package.extra-patches]]
comments = [
    "Relax strict dependency on rayon",
]
file = "rust-average-0.15.1-Relax_strict_dependencies.diff"
number = 10
```

Comment 1 Fabio Valentini 2024-07-04 21:24:42 UTC
Please use "rust2rpm -p" to make patches for Cargo.toml.
The "extra-patches" feature is not meant to be used for this (and *if* you use it for this purpose, the result might be slightly broken).

Comment 2 Cristian Le 2024-07-05 13:06:09 UTC
Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/1ea06512b2d4cfeb0e34cfc0e922d06af399e8a6/rust-average/rust-average.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07500437-rust-average/rust-average-0.15.1-1.fc41.src.rpm

rust2rpm.toml
```toml
[package]
cargo-toml-patch-comments = [
    "- Relax strict dependency on rayon",
    "- Bump sketches-ddsketch dependency",
]
```

average-fix-metadata.diff
```
--- average-0.15.1/Cargo.toml	1970-01-01T00:00:01+00:00
+++ average-0.15.1/Cargo.toml	2024-07-05T12:51:34.423669+00:00
@@ -75,11 +75,11 @@
 default-features = false
 
 [dependencies.rayon]
-version = "=1.7"
+version = "1.7"
 optional = true
 
 [dependencies.rayon-core]
-version = "=1.11"
+version = "1.11"
 optional = true
 
 [dependencies.serde]

```

Comment 3 Fedora Review Service 2024-07-06 05:44:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7712615
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283684-rust-average/fedora-rawhide-x86_64/07712615-rust-average/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-average
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2024-07-06 10:31:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7712834
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283684-rust-average/fedora-rawhide-x86_64/07712834-rust-average/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-average
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fabio Valentini 2024-07-06 13:31:58 UTC
Looks like you uploaded and / or linked an old version of the SRPM?

Comment 6 Cristian Le 2024-07-06 16:33:38 UTC
Ack, you're right:

Spec URL: https://github.com/LecrisUT/rust-metris-rpmspec/raw/1ea06512b2d4cfeb0e34cfc0e922d06af399e8a6/rust-average/rust-average.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rust-metris-rpmspec-main/fedora-rawhide-x86_64/07711121-rust-average/rust-average-0.15.1-1.fc41.src.rpm

rust2rpm.toml
```toml
[package]
cargo-toml-patch-comments = [
    "- Relax strict dependency on rayon",
    "- Bump sketches-ddsketch dependency",
]
```

average-fix-metadata.diff
```
--- average-0.15.1/Cargo.toml	1970-01-01T00:00:01+00:00
+++ average-0.15.1/Cargo.toml	2024-07-05T12:51:34.423669+00:00
@@ -75,11 +75,11 @@
 default-features = false
 
 [dependencies.rayon]
-version = "=1.7"
+version = "1.7"
 optional = true
 
 [dependencies.rayon-core]
-version = "=1.11"
+version = "1.11"
 optional = true
 
 [dependencies.serde]

```

Comment 7 Cristian Le 2024-07-08 11:17:33 UTC
[fedora-review-service-build]

Comment 8 Fabio Valentini 2024-07-11 11:59:03 UTC
This comment seems to be outdated:
> Bump sketches-ddsketch dependency

Other than that, looks good to me now.
Please take care when re-importing this package after un-retirement.

===

Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

(skip as appropriate for unretirements)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)


Note You need to log in before you can comment on or make changes to this bug.