Bug 2283851 - Review Request: rust-primes - Package for calculating primes using the Sieve of Eratosthenes
Summary: Review Request: rust-primes - Package for calculating primes using the Sieve ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/primes
Whiteboard:
Depends On:
Blocks: 2283850
TreeView+ depends on / blocked
 
Reported: 2024-05-29 18:11 UTC by Cristian Le
Modified: 2024-06-12 01:31 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-03 08:20:21 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Cristian Le 2024-05-29 18:11:46 UTC
Spec URL: https://github.com/LecrisUT/rusty_parserk-paseto-rpmspec/raw/6af57bdf59c2f18ad3641b9b606efc8881a9a096/rust-primes/rust-primes.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rusty_parserk-paseto-rpmspec-main/fedora-rawhide-x86_64/07501927-rust-primes/rust-primes-0.3.0-1.fc41.src.rpm
Description: Dependency for `rust-rusty_paseto` -> `atuin`
Fedora Account System Username: lecris

rust2rpm.toml
```toml
[requires]
build = [
    "tomcli",
]

[scripts.prep]
post = [
    "# Do not depend on criterion; it is needed only for benchmarks.",
    "tomcli set Cargo.toml del dev-dependencies.criterion",
]

[package]
summary = "Package for calculating primes using the Sieve of Eratosthenes"
```

Comment 1 Fedora Review Service 2024-05-29 18:15:55 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7504973
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2283851-rust-primes/fedora-rawhide-x86_64/07504973-rust-primes/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Robert-André Mauchin 🐧 2024-06-01 20:18:33 UTC
This package was generated using rust2rpm, which simplifies the review.

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

    [x] The latest version is packaged or packaging an earlier version is justified.
    [x] The License tag reflects the package contents and uses the correct identifiers.
    [x] The package builds successfully in mock.
    [x] Package is installable (checked by fedora-review).
    [x] There are no relevant rpmlint errors.
    [x] The package runs tests in %check.
    [x] The package's binaries don't conflict with binaries already in the distribution.
    [x] There are no %{_bindir}/* wildcards in %files.
    [x] The package complies with the Rust and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

    [ ] Add the package to release-monitoring.org
    [ ] Add the package to Koschei
    [ ] Give rust-sig privileges (at least commit) on the package
    [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-06-03 08:02:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-primes

Comment 4 Fedora Update System 2024-06-03 08:18:05 UTC
FEDORA-2024-5a3247951a (rust-primes-0.3.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5a3247951a

Comment 5 Fedora Update System 2024-06-03 08:20:21 UTC
FEDORA-2024-5a3247951a (rust-primes-0.3.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2024-06-03 08:36:44 UTC
FEDORA-2024-fb8edf1a58 (rust-primes-0.3.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-fb8edf1a58

Comment 7 Fedora Update System 2024-06-03 08:36:44 UTC
FEDORA-2024-003b36b097 (rust-primes-0.3.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-003b36b097

Comment 8 Fedora Update System 2024-06-04 01:06:27 UTC
FEDORA-2024-003b36b097 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-003b36b097`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-003b36b097

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-06-04 03:44:41 UTC
FEDORA-2024-fb8edf1a58 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-fb8edf1a58`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fb8edf1a58

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-06-12 01:10:54 UTC
FEDORA-2024-fb8edf1a58 (rust-primes-0.3.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2024-06-12 01:31:47 UTC
FEDORA-2024-003b36b097 (rust-primes-0.3.0-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.