Bug 2284119 - Review Request: perl-UUID - Universally Unique Identifier library for Perl
Summary: Review Request: perl-UUID - Universally Unique Identifier library for Perl
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2284046
TreeView+ depends on / blocked
 
Reported: 2024-05-31 13:28 UTC by Petr Pisar
Modified: 2024-06-03 11:43 UTC (History)
2 users (show)

Fixed In Version: perl-UUID-0.35-1.fc41
Clone Of:
Environment:
Last Closed: 2024-06-03 11:43:03 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2024-05-31 13:28:46 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-UUID/perl-UUID.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-UUID/perl-UUID-0.35-1.fc41.src.rpm
Description:
The UUID library is used to generate unique identifiers for objects that may
be accessible beyond the local system. The generated UUIDs are compatible with
those created by the Open Software Foundation (OSF) Distributed Computing
Environment (DCE).

All generated UUIDs are either version 1, 3, 4, 5, 6, or version 7. And all
are variant 1, meaning compliant with the OSF DCE standard as described in
RFC 4122. Versions 6 and 7 are not standardized. They are presented here as
proposed in RFC 4122bis, version 14, and may change in the future.


Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2024-06-03 10:02:35 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please add
     perl-devel - needed for XS code
     perl(File::Temp) - used in t/3unique/, t/5defer/

$ rpm -qp --requires perl-UUID-0.35-1.fc41.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.3)(64bit)
      1 libc.so.6(GLIBC_2.38)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit)
      1 perl(Carp)
      1 perl(DynaLoader)
      1 perl(Exporter)
      1 perl-libs
      1 perl(:MODULE_COMPAT_5.38.2)
      1 perl(strict)
      1 perl(Time::HiRes)
      1 perl(vars)
      1 perl(:VERSION) >= 5.5.0
      1 perl(warnings)
      1 rtld(GNU_HASH)
$ rpm -qp --requires perl-UUID-tests-0.35-1.fc41.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Config)
      1 perl(Digest::SHA1)
      1 perl(Exporter)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(strict) 
      1 perl-Test-Harness
      1 perl(Test::More) >= 0.88
      1 perl(threads)
      1 perl(Thread::Semaphore)
      1 perl(threads::shared)
      1 perl(Time::HiRes)
      1 perl(Try::Tiny)
      1 perl(UUID)
      1 perl-UUID = 0.35-1.fc41
      1 perl(vars)
      1 perl(version) >= 0.77
      1 perl(warnings) 
      1 /usr/bin/sh
Binary requires are Ok.

$ rpm -qp --provides perl-UUID-0.35-1.fc41.x86_64.rpm | sort | uniq -c
      1 perl(UUID) = 0.35
      1 perl-UUID = 0.35-1.fc41
      1 perl-UUID(x86-64) = 0.35-1.fc41
$ rpm -qp --provides perl-UUID-tests-0.35-1.fc41.noarch.rpm | sort | uniq -c
      1 perl-UUID-tests = 0.35-1.fc41
Binary provides are Ok.

$ rpmlint ./perl-UUID*
========================================= rpmlint session starts =========================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

perl-UUID-tests.noarch: W: no-documentation
perl-UUID-tests.noarch: W: files-duplicate /usr/libexec/perl-UUID/t/3names/v3bare.t /usr/libexec/perl-UUID/t/1uuid/v3.t
=== 3 packages and 1 specfiles checked; 0 errors, 2 warnings, 12 filtered, 0 badness; has taken 0.5 s ====

Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items.

Resolution:
Approved

Comment 2 Fedora Admin user for bugzilla script actions 2024-06-03 10:21:14 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-UUID

Comment 3 Petr Pisar 2024-06-03 10:31:05 UTC
Thanks for the review. I added perl-devel to build-requires and "perl(File::Temp) >= 0.10" to run-requires of the tests subpackage.


Note You need to log in before you can comment on or make changes to this bug.