Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/centos-stream-10-x86_64/07514059-trayscale/trayscale.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/centos-stream-10-x86_64/07514059-trayscale/trayscale-0.12.3-1.src.rpm Description: An unofficial GUI wrapper around the Tailscale CLI client. Fedora Account System Username: jonathanspw
Taking this review.
Initial spec review: > Release: 1 Missing DistTag. > %if %{with vendor} > # see create-vendor-tarball.sh in this distgit repo > Source0: trayscale-%{version}-vendored.tar.xz > %else > Source0: %{gosource} > %endif The script needs to be included as a source so that it's part of the SRPM. > desktop-file-validate %{buildroot}%{_datadir}/applications/dev.deedles.Trayscale.desktop > appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/dev.deedles.Trayscale.metainfo.xml This should be in %check
Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fedora-rawhide-x86_64/07515426-trayscale/trayscale.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fedora-rawhide-x86_64/07515426-trayscale/trayscale-0.12.3-1.fc41.src.rpm
> %if %{with vendor} > # see create-vendor-tarball.sh in this distgit repo > Source0: trayscale-%{version}-vendored.tar.xz > Source1: create-vendor-tarball.sh > %else > Source0: %{gosource} > %endif Sources are not allowed to be conditionalized. You should probably just use the vendored sources and have a conditional in prep to strip bundled deps when not being used.
Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fedora-rawhide-x86_64/07622477-trayscale/trayscale.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/trayscale/fedora-rawhide-x86_64/07622477-trayscale/trayscale-0.12.3-1.fc41.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7623146 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284159-trayscale/fedora-rawhide-x86_64/07623146-trayscale/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated through go2rpm, simplifying the review considerably. - Conforms to packaging guidelines (go2rpm generated spec) - license correct and valid - builds and installs PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/trayscale