Spec URL: https://dcavalca.fedorapeople.org/review/rust-apple-bom/rust-apple-bom.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-apple-bom/rust-apple-bom-0.2.0-1.fc41.src.rpm Description: Apple Bill of Materials (BOM) data format. Fedora Account System Username: dcavalca
Copr build: https://copr.fedorainfracloud.org/coprs/build/7522385 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284291-rust-apple-bom/fedora-rawhide-x86_64/07522385-rust-apple-bom/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> %package -n %{crate} > Summary: %{summary} > # FIXME: paste output of %%cargo_license_summary here > License: # FIXME > # LICENSE.dependencies contains a full license breakdown > > %description -n %{crate} %{_description} > > %files -n %{crate} > %license LICENSE-APACHE > %license LICENSE-MIT > %license LICENSE.dependencies > %doc CHANGELOG.md > %doc README.md > %{_bindir}/odumpbom Looks like you missed that this provides a binary too? If you only need the library interface, I would recommend to use a rust2rpm.toml config file with ``` [package] cargo-install-bin = false ```
Ah good catch, we should keep the binary too as it can be useful here. Spec URL: https://dcavalca.fedorapeople.org/review/rust-apple-bom/rust-apple-bom.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-apple-bom/rust-apple-bom-0.2.0-1.fc41.src.rpm Changelog: - add license tag for binary subpackage
Thanks, looks good to me. You can simplify the license tag to "MIT AND (Apache-2.0 OR MIT)" though. keeping the second "MIT OR Apache-2.0" is redundant. You might also want to think about whether the name of the application package is OK. Should it really be "apple-bom" or would "odumpbom" to match the binary name be more appropriate? === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-apple-bom
FEDORA-2024-5966fd9217 (rust-apple-bom-0.2.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5966fd9217
FEDORA-2024-037c6464f5 (rust-apple-bom-0.2.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-037c6464f5
FEDORA-2024-b75c17f2d8 (rust-apple-bom-0.2.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b75c17f2d8
FEDORA-2024-5966fd9217 (rust-apple-bom-0.2.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-037c6464f5 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-037c6464f5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-037c6464f5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b75c17f2d8 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b75c17f2d8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b75c17f2d8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-037c6464f5 (rust-apple-bom-0.2.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-b75c17f2d8 (rust-apple-bom-0.2.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.