Spec URL: https://raw.githubusercontent.com/thebeanogamer/ansible-collection-dellemc-openmanage/4ec4e48fadf1d7bb87d6b4709b79411a9d4fb513/ansible-collection-dellemc-openmanage.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-rawhide-x86_64/07521130-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage-9.3.0-1.fc41.src.rpm Description: Dell OpenManage collection for Ansible Fedora Account System Username: thebeanogamer COPR Build: https://copr.fedorainfracloud.org/coprs/thebeanogamer/ansible-collection-dellemc-openmanage/build/7521130/
Copr build: https://copr.fedorainfracloud.org/coprs/build/7522372 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284297-ansible-collection-dellemc-openmanage/fedora-rawhide-x86_64/07522372-ansible-collection-dellemc-openmanage/fedora-review/review.txt Found issues: - License file idrac_license.yml is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file idrac_license.yml is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text This is a false positive - this file is a module and play - There are some files with a BSD license: plugins/module_utils/dellemc_idrac.py: BSD 2-Clause License plugins/module_utils/idrac_redfish.py: BSD 2-Clause License plugins/module_utils/ome.py: BSD 2-Clause License plugins/module_utils/redfish.py: BSD 2-Clause License plugins/module_utils/session_utils.py: BSD 2-Clause License plugins/module_utils/utils.py: BSD 2-Clause License This should be noted and added to the license tag. Might be worth bringing up with upstream as well. - Note that the patch is a downstream only patch - Should update to the latest - We should get upstream to switch to unittest.mock ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License, Version 3", "GNU General Public License v3.0 or later and/or GNU General Public License, Version 2", "BSD 2-Clause License". 926 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/ansible-collection-dellemc- openmanage/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/ansible/collections, /usr/share/ansible, /usr, /usr/share/doc, /usr/share/licenses, /usr/share, /usr/share/ansible/collections/ansible_collections [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/ansible/collections/ansible_collections, /usr/share, /usr/share/ansible/collections, /usr/share/licenses, /usr/share/doc, /usr/share/ansible, /usr [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 942101 bytes in 110 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: Source 3 is not passed to gpgverify. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: ansible-collection-dellemc-openmanage-9.3.0-1.fc41.noarch.rpm ansible-collection-dellemc-openmanage-9.3.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpffaosb76')] checks: 32, packages: 2 ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/negative_scenarios_with_maintenance_window/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/default/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/default/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/system_attr/cleanup.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/idrac_attr/cleanup.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/lifecycle_controller_attr/cleanup.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/redfish_storage_volume/molecule/apply_time_onreset_reboot_server_true_force_reboot_true/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/idrac_attr/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/lifecycle_controller_attr/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/molecule/system_attr/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/clear_pending_attributes/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_boot/molecule/boot_options_using_boot_option_reference_enabled_true/molecule.yml:(and 12 more) ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/redfish_storage_volume/tests/inventory /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_attributes/tests/inventory:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/tests/inventory:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_boot/tests/inventory:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_export_server_config_profile/tests/inventory:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_firmware/tests/inventory:(and 8 more) ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_boot/molecule/boot_source_override_enabled_as_continuous_reset_type_none/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/reset_bios/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/reset_bios_with_reset_type_as_force_restart/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_immediate_with_jobwait/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_immediate/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_with_maintenance_window/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_on_reset/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_bios/molecule/update_attributes_on_reset_with_maintenance_window/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_job_queue/molecule/delete_job/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_firmware/molecule/default/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_firmware/molecule/negative_scenarios/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_gather_facts/molecule/backplane/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_gather_facts/molecule/bios/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_gather_facts/molecule/controller/molecule.yml:(and 24 more) ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/nfs_share/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/cifs_share/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/http_share/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/http_share_with_proxy_parameters/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/https_share/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/https_share_with_proxy_parameters/molecule.yml:(and 1 more) ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_server_powerstate/molecule/default/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/default/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/import_buffer_xml/prepare.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_import_server_config_profile/molecule/import_buffer_json/prepare.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152150/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152120/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152146/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152148/molecule.yml:/usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152149/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/default/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/idrac_user/molecule/TC-152147/molecule.yml ansible-collection-dellemc-openmanage.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/redfish_firmware/molecule/negative/molecule.yml /usr/share/ansible/collections/ansible_collections/dellemc/openmanage/roles/redfish_firmware/molecule/default/molecule.yml 2 packages and 0 specfiles checked; 0 errors, 14 warnings, 7 filtered, 0 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "ansible-collection-dellemc-openmanage". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://raw.githubusercontent.com/dell/dellemc-openmanage-ansible-modules/v9.3.0/galaxy.yml : CHECKSUM(SHA256) this package : 2d16a9688e7cc27bcbaba72205c56e7b880b1644ed20ad2db19e46ba2cb397d7 CHECKSUM(SHA256) upstream package : 2d16a9688e7cc27bcbaba72205c56e7b880b1644ed20ad2db19e46ba2cb397d7 https://github.com/dell/dellemc-openmanage-ansible-modules/releases/download/v9.3.0/dellemc-openmanage-9.3.0.tar.gz.sign : CHECKSUM(SHA256) this package : 0e83902dba7db3eabfb5deff729d44e0343bccaa12e61afbfd76c4f449ae3fe0 CHECKSUM(SHA256) upstream package : 0e83902dba7db3eabfb5deff729d44e0343bccaa12e61afbfd76c4f449ae3fe0 https://github.com/dell/dellemc-openmanage-ansible-modules/releases/download/v9.3.0/dellemc-openmanage-9.3.0.tar.gz : CHECKSUM(SHA256) this package : 7bf1471720d43e929da524758cdf5ad70dbcc8e402edf111ef41d7747dc56110 CHECKSUM(SHA256) upstream package : 7bf1471720d43e929da524758cdf5ad70dbcc8e402edf111ef41d7747dc56110 Requires -------- ansible-collection-dellemc-openmanage (rpmlib, GLIBC filtered): (ansible-core or (ansible < 2.10.0 with ansible >= 2.9.10)) ansible-collection(ansible.utils) ansible-collection(ansible.windows) isomd5sum python3dist(netaddr) python3dist(omsdk) syslinux wget xorriso Provides -------- ansible-collection-dellemc-openmanage: ansible-collection(dellemc.openmanage) ansible-collection-dellemc-openmanage Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name ansible-collection-dellemc-openmanage --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, SugarActivity, C/C++, Python, PHP, Perl, Ocaml, fonts, Haskell, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks for having a look at this! > There are some files with a BSD license. This should be noted and added to the license tag. Might be worth bringing up with upstream as well. Added to spec https://github.com/thebeanogamer/ansible-collection-dellemc-openmanage/commit/cc0f8742b96051a96b73c5ae3374f4fad8a258bf. Raised upstream as https://github.com/dell/dellemc-openmanage-ansible-modules/issues/754. > Note that the patch is a downstream only patch https://github.com/thebeanogamer/ansible-collection-dellemc-openmanage/commit/6e0b1dbf01ebcf64591d40a0c5c36e51bba70daa > Should update to the latest Fixed https://github.com/thebeanogamer/ansible-collection-dellemc-openmanage/commit/ea46f98816c086f9cdedfaeafbbded69998fac9f > We should get upstream to switch to unittest.mock Raised upstream as https://github.com/dell/dellemc-openmanage-ansible-modules/issues/755 Spec URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-41-x86_64/08159975-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-41-x86_64/08159975-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage-9.7.0-1.fc41.src.rpm
Created attachment 2052913 [details] The .spec file difference from Copr build 7522372 to 8159981
Copr build: https://copr.fedorainfracloud.org/coprs/build/8159981 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284297-ansible-collection-dellemc-openmanage/fedora-rawhide-x86_64/08159981-ansible-collection-dellemc-openmanage/fedora-review/review.txt Found issues: - python3-mock is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ - License file idrac_license.yml is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Daniel Milnes from comment #3) > Thanks for having a look at this! > > > There are some files with a BSD license. This should be noted and added to the license tag. Might be worth bringing up with upstream as well. > Added to spec > https://github.com/thebeanogamer/ansible-collection-dellemc-openmanage/ > commit/cc0f8742b96051a96b73c5ae3374f4fad8a258bf. Raised upstream as > https://github.com/dell/dellemc-openmanage-ansible-modules/issues/754. You'll want to note in comments which files are BSD. Also good to add the link to the upstream issue as well.
> You'll want to note in comments which files are BSD. Also good to add the link to the upstream issue as well. Done and done (https://github.com/thebeanogamer/ansible-collection-dellemc-openmanage/commit/3e8a50c77ac05e3a39ad8c03e2ab8a5b7ecbc52c) Spec URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-rawhide-x86_64/08160002-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-rawhide-x86_64/08160002-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage-9.7.0-1.fc41.src.rpm
There seems to be some problem with the following file. SRPM URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-rawhide-x86_64/08160002-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage-9.7.0-1.fc41.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Not sure why COPR failed to upload those Spec URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-41-x86_64/08160002-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-41-x86_64/08160002-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage-9.7.0-1.fc41.src.rpm
Created attachment 2052930 [details] The .spec file difference from Copr build 8159981 to 8160083
Copr build: https://copr.fedorainfracloud.org/coprs/build/8160083 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2284297-ansible-collection-dellemc-openmanage/fedora-rawhide-x86_64/08160083-ansible-collection-dellemc-openmanage/fedora-review/review.txt Found issues: - python3-mock is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ - License file idrac_license.yml is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I don't see comments about the license files - you really do want something like: # All file ares GPL-3.0-only except for: # plugins/module_utils/dellemc_idrac.py: BSD 2-Clause License # plugins/module_utils/idrac_redfish.py: BSD 2-Clause License # plugins/module_utils/ome.py: BSD 2-Clause License # plugins/module_utils/redfish.py: BSD 2-Clause License # plugins/module_utils/session_utils.py: BSD 2-Clause License # plugins/module_utils/utils.py: BSD 2-Clause License # Clarification requested upstream at https:...
(In reply to Orion Poplawski from comment #12) > I don't see comments about the license files - you really do want something > like: > > # All file ares GPL-3.0-only except for: > # plugins/module_utils/dellemc_idrac.py: BSD 2-Clause License > # plugins/module_utils/idrac_redfish.py: BSD 2-Clause License > # plugins/module_utils/ome.py: BSD 2-Clause License > # plugins/module_utils/redfish.py: BSD 2-Clause License > # plugins/module_utils/session_utils.py: BSD 2-Clause License > # plugins/module_utils/utils.py: BSD 2-Clause License > # Clarification requested upstream at https:... Fair enough, I've stuck that in the spec: Spec URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-41-x86_64/08160440-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/ansible-collection-dellemc-openmanage/fedora-41-x86_64/08160440-ansible-collection-dellemc-openmanage/ansible-collection-dellemc-openmanage-9.7.0-1.fc41.src.rpm
The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collection-dellemc-openmanage
FEDORA-2024-174527b294 (ansible-collection-dellemc-openmanage-9.7.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-174527b294
FEDORA-2024-174527b294 (ansible-collection-dellemc-openmanage-9.7.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-1e3bf3b0f4 (ansible-collection-dellemc-openmanage-9.7.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1e3bf3b0f4
FEDORA-2024-b384d97d9b (ansible-collection-dellemc-openmanage-9.7.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b384d97d9b
FEDORA-2024-9be204b8d9 (ansible-collection-dellemc-openmanage-9.7.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9be204b8d9
FEDORA-2024-9be204b8d9 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9be204b8d9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9be204b8d9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b384d97d9b has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b384d97d9b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b384d97d9b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-1e3bf3b0f4 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1e3bf3b0f4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1e3bf3b0f4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-1e3bf3b0f4 (ansible-collection-dellemc-openmanage-9.7.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-9be204b8d9 (ansible-collection-dellemc-openmanage-9.7.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-b384d97d9b (ansible-collection-dellemc-openmanage-9.7.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.