Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-fr.spec SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-fr-0.20060915-1.src.rpm Description: French hunspell dictionaries Similar to 227811
Any progress on this review, I believe it's the last of the hunspell dictionary outstanding.
Xavier has assigned it to himself for review and I do not think it would be polite from m part to step on his shoes.
taking over the review in order to finish with all the set. GOOD - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream , sha1sum 1591bf44789a78fda5d84c5820fecb87e19efb27 fr_FR-1990.zip - the package builds in mock for devel/x86_64, generates a noarch (which is consistent with the fact that basically it includes only 3 text files) - the license GPL stated in the tag is the same as the web site says and is included in the package - there are only 2 files (word lists) + a short doc with instructions and license clearance, so no need for -doc and no .la, .pc, static files - no missing BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of other files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - rpmlint output is silent - code, not content - nothing in %doc affects runtime - no need for .desktop file APPROVED
27896 (hunspell-fr): Build on target fedora-development-extras succeeded.