This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours
Bug 228496 - Review Request: hunspell-ru - Russian hunspell dictionaries
Review Request: hunspell-ru - Russian hunspell dictionaries
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2007-02-13 07:09 EST by Caolan McNamara
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-15 09:35:54 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
wolfy: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Caolan McNamara 2007-02-13 07:09:41 EST
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-ru.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-ru-0.20040406-1.src.rpm
Description: Russian hunspell dictionaries


Similar to 227811
Comment 1 manuel wolfshant 2007-02-14 05:58:33 EST
GOOD

- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- source matches upstream , sha1sum 
176b8983980395c8e386884f4f08a6a5bb0aed63  ru_RU.zip
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license BSD stated in the tag is the same as the web site says; it is
not included in the package because upstream does not include it either; however
 a doc is included which says:
"Permission to use, copy, redistribute is granted.  Permission to
redistribute modifications in patch form is granted.  Permission
to redistribute binaries made of modified sources is granted.
All other rights reserved."
I guess this ressembles BSD well enough.
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED
Comment 2 Caolan McNamara 2007-02-15 09:35:54 EST
 27642 (hunspell-ru): Build on target fedora-development-extras succeeded.

Note You need to log in before you can comment on or make changes to this bug.