Bug 228501 - Review Request: hunspell-th - Thai hunspell dictionaries
Review Request: hunspell-th - Thai hunspell dictionaries
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2007-02-13 07:26 EST by Caolan McNamara
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-15 03:59:43 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wolfy: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Caolan McNamara 2007-02-13 07:26:44 EST
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-th.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-th-0.20050530-1.src.rpm
Description: Thai hunspell dictionaries


Similar to 227811
Comment 1 manuel wolfshant 2007-02-14 06:53:24 EST
Upstream version has been updated, current one is 12-Dec-2006. Therefore the
upstream source and the one included in the src.rpm do not coincide.

GOOD

- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license LGPL stated in the tag is the same as the web site says and is not
 included in the package because upstream does not include it either; it is
however mentioned in a bundled README
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file 

MUSTFIX
36e94fd62cc246ebb083fbab8ce200b07a2934c2  th_TH.zip (upstream)
d0ec83646ea1d0a4fd1262dec44ac97e59bcfefa  th_TH.zip (bundled in src.rpm)

SHOULD
Please ask upstream to include the license in the archive
Comment 2 Caolan McNamara 2007-02-14 07:05:41 EST
updated to latest as
http://people.redhat.com/caolanm/hunspell/hunspell-th-0.20061212-1.src.rpm
Comment 3 manuel wolfshant 2007-02-14 07:14:54 EST
Problems fixed. package APPROVED
Comment 4 Caolan McNamara 2007-02-15 03:59:43 EST
 27628 (hunspell-th): Build on target fedora-development-extras succeeded.

Note You need to log in before you can comment on or make changes to this bug.