Bug 228627 - Review Request: perl-Acme-Damn - 'Unbless' Perl objects
Review Request: perl-Acme-Damn - 'Unbless' Perl objects
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
http://search.cpan.org/dist/Acme-Damn/
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2007-02-13 19:56 EST by Chris Weyl
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-20 00:48:07 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wtogami: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Chris Weyl 2007-02-13 19:56:13 EST
SRPM URL: http://home.comcast.net/~ckweyl/perl-Acme-Damn-0.03-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Acme-Damn.spec

Description:
Acme::Damn provides a single routine, damn(), which takes a blessed
reference (a Perl object), and unblesses it, to return the original
reference. I can't think of any reason why you might want to do this,
but just because it's of no use doesn't mean that you shouldn't be
able to do it.
Comment 1 Parag AN(पराग) 2007-02-13 23:32:29 EST
mock build is fine.
got rpmlint warning as
W: perl-Acme-Damn summary-not-capitalized 'Unbless' Perl objects
Summary doesn't begin with a capital letter.
Comment 2 Chris Weyl 2007-02-14 00:15:31 EST
Probably caused by the leading '. If it's a problem, I can reword the summary...
Comment 3 Chris Weyl 2007-02-14 00:19:15 EST
I'm interperting this as a rpmlint bug, as unbless is indeed capitalized in the
summary; it's just after a quote.  Reported as bug 228645.
Comment 4 Chris Weyl 2007-02-14 13:18:54 EST
Updated to work around rpmlint:

SRPM URL: http://home.comcast.net/~ckweyl/perl-Acme-Damn-0.03-2.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Acme-Damn.spec
Comment 5 Parag AN(पराग) 2007-02-15 00:31:15 EST
Thanks for Changing Summary and making rpmlint happy :)
Comment 6 Parag AN(पराग) 2007-02-15 00:41:05 EST
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url 
02a3c8b947d3f2888bc2455f7405f7c1  Acme-Damn-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/1compile....ok
t/2damn.......ok
t/3aliases....ok
t/4name.......ok
t/5bad........ok
All tests successful.
Files=5, Tests=75,  1 wallclock secs ( 0.21 cusr +  0.05 csys =  0.26 CPU)
+Provides: Damn.so perl(Acme::Damn) = 0.03

APPROVED.
Comment 7 Chris Weyl 2007-02-17 15:44:32 EST
Let's try this here -- please branch for devel :)
Comment 8 Chris Weyl 2007-02-19 20:12:49 EST
After actually reading CVSAdminProcedure *sigh*, I realize my request was
somewhat botched (yet completed--thanks!) and that I could have requested this
at the same time:

Please branch for FC-5, FC-6.
Comment 9 Chris Weyl 2007-02-20 00:47:35 EST
Branched and built for devel, fc[56].

Thanks for the review! :)

Note You need to log in before you can comment on or make changes to this bug.