Bug 228693 - Bad: cfi_cmdset_0001 sets incorrect write/erase wait timeout if jedec_probe was used to detect a flash
Summary: Bad: cfi_cmdset_0001 sets incorrect write/erase wait timeout if jedec_probe w...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.0
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: Ric Wheeler
QA Contact: Brian Brock
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-02-14 15:20 UTC by Ekaterina Nosova
Modified: 2023-09-14 01:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-02 13:18:19 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Ekaterina Nosova 2007-02-14 15:20:42 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; InfoPath.1; .NET CLR 2.0.50727)

Description of problem:
If a map driver uses jedec_probe to detect a flash (e.g. ST M50FW080), then erase and write operations on this flash breaks by timeout.
The following patch helps to fix the problem:

diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
index f69184a..fed9d5b 100644
--- a/drivers/mtd/chips/cfi_cmdset_0001.c
+++ b/drivers/mtd/chips/cfi_cmdset_0001.c
@@ -402,6 +402,12 @@ struct mtd_info *cfi_cmdset_0001(struct map_info *map, int primary)
                cfi->chips[i].erase_time = 1000<<cfi->cfiq-BlockEraseTimeoutTyp;
                cfi->chips[i].ref_point_counter = 0;
                init_waitqueue_head(&(cfi->chips[i].wq));
+
+               /* If no times specified, put some reasonable defaults in */
+               if (!cfi->chips[i].WordWriteTimeoutTyp)
+                       cfi->chips[i].word_write_time = 100;
+               if (!cfi->chips[i].BlockEraseTimeoutTyp)
+                       cfi->chips[i].erase_time = 2000000;
        }

        map->fldrv = &cfi_intelext_chipdrv;


Version-Release number of selected component (if applicable):
kernel 2.6.18-1.2747.el5

How reproducible:
Always


Steps to Reproduce:
1. Load Motorola atca7221 map driver
2. Try to erase flash on /dev/mtd0 or /dev/mtd1
3. See 'Timeout expired' messages
(Contact David Woodhouse dwmw2 for more details)

Actual Results:


Expected Results:


Additional info:

Comment 4 RHEL Program Management 2014-03-07 13:43:59 UTC
This bug/component is not included in scope for RHEL-5.11.0 which is the last RHEL5 minor release. This Bugzilla will soon be CLOSED as WONTFIX (at the end of RHEL5.11 development phase (Apr 22, 2014)). Please contact your account manager or support representative in case you need to escalate this bug.

Comment 5 RHEL Program Management 2014-06-02 13:18:19 UTC
Thank you for submitting this request for inclusion in Red Hat Enterprise Linux 5. We've carefully evaluated the request, but are unable to include it in RHEL5 stream. If the issue is critical for your business, please provide additional business justification through the appropriate support channels (https://access.redhat.com/site/support).

Comment 6 Red Hat Bugzilla 2023-09-14 01:11:03 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.