Bug 228713 - [RHEL4] [patch] cid-2 remove dead code in lib/ss/help.c
[RHEL4] [patch] cid-2 remove dead code in lib/ss/help.c
Status: CLOSED NOTABUG
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: e2fsprogs (Show other bugs)
4.4
All Linux
medium Severity medium
: ---
: ---
Assigned To: Eric Sandeen
Jay Turner
:
Depends On:
Blocks: 234251 239341
  Show dependency treegraph
 
Reported: 2007-02-14 11:30 EST by Bryn M. Reeves
Modified: 2015-01-07 19:15 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-05-30 14:33:42 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Remove invariant (code != 0) check in lib/ss/help.c (682 bytes, patch)
2007-02-14 11:31 EST, Bryn M. Reeves
no flags Details | Diff

  None (edit)
Description Bryn M. Reeves 2007-02-14 11:30:59 EST
Description of problem:
lib/ss/help.c contains the following lines in ss_help():

    request_name = ss_current_request(sci_idx, &code);
    if (code != 0) { 
        ss_perror(sci_idx, code, "");
        return;         /* no ss_abort_line, if invalid invocation */
    }

However, ss_current_request is defined in lib/ss/ss_internal.h as:

#define ss_current_request(sci_idx,code_ptr)    \
     (*code_ptr=0,ss_info(sci_idx)->current_request)

Since this clears &code, the conditional following the macro is not necessary.


Version-Release number of selected component (if applicable):
e2fsprogs-1.35-12.4.EL4

How reproducible:
Not really reproducible, since the ss_perror line is never executed anyway.
Comment 1 Bryn M. Reeves 2007-02-14 11:31:00 EST
Created attachment 148063 [details]
Remove invariant (code != 0) check in lib/ss/help.c
Comment 5 RHEL Product and Program Management 2007-05-09 03:42:15 EDT
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 6 Eric Sandeen 2007-05-29 16:05:14 EDT
This patch was not accepted upstream
Comment 7 Eric Sandeen 2007-05-30 14:33:42 EDT
since this was NAK'd upstream, coupled with the fact that dead code removal
isn't really acceptable for rhel changes, setting this one to NOTABUG.

http://lists.openwall.net/linux-ext4/2007/03/18/4

Note You need to log in before you can comment on or make changes to this bug.