Bug 2290574 - Review Request: rust-unicase_serde - Serde Serialization and Deserialization for UniCase crate
Summary: Review Request: rust-unicase_serde - Serde Serialization and Deserialization ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/unicase_serde
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-06-05 15:34 UTC by wojnilowicz
Modified: 2024-07-07 08:17 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-07 08:11:58 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description wojnilowicz 2024-06-05 15:34:28 UTC
Spec URL: https://wojnilowicz.fedorapeople.org/rust-unicase_serde.spec
SRPM URL: https://wojnilowicz.fedorapeople.org/rust-unicase_serde-0.1.0-1.fc39.src.rpm

Description:
Serde Serialization and Deserialization for UniCase crate.

Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and the unicase_serde package is in its requirements chain. The chain is as follows: aw-server-rust->unicase_serde.

Comment 1 Fedora Review Service 2024-06-05 15:53:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7532831
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290574-rust-unicase_serde/fedora-rawhide-x86_64/07532831-rust-unicase_serde/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-07-05 13:22:52 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2024-07-07 07:49:26 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unicase_serde

Comment 4 Fedora Update System 2024-07-07 08:07:02 UTC
FEDORA-2024-3fd60abf8d (rust-unicase_serde-0.1.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3fd60abf8d

Comment 5 Fedora Update System 2024-07-07 08:11:58 UTC
FEDORA-2024-3fd60abf8d (rust-unicase_serde-0.1.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 wojnilowicz 2024-07-07 08:17:47 UTC
Thank you for the review! Everything's done.


Note You need to log in before you can comment on or make changes to this bug.