Bug 2290871 - Review Request: foosnapper - Automatic filesystem snapshooter
Summary: Review Request: foosnapper - Automatic filesystem snapshooter
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Wouters
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/FoobarOy/foosnapper
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-06-07 12:40 UTC by Kim B. Heino
Modified: 2024-06-19 12:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
paul.wouters: fedora-review?


Attachments (Terms of Use)
The .spec file difference from Copr build 7554824 to 7627461 (1.27 KB, patch)
2024-06-19 11:16 UTC, Fedora Review Service
no flags Details | Diff

Description Kim B. Heino 2024-06-07 12:40:16 UTC
Spec URL: https://heino.kim/foosnapper/foosnapper.spec
SRPM URL: https://heino.kim/foosnapper/foosnapper-1.2-1.fc40.src.rpm
Description: Automatic filesystem snapshooter, supporting Stratis and Btrfs.
Fedora Account System Username: kimheino

I'm the foosnapper author.
I'm already packaging foomuuri (I'm the author), munin and sawfish for Fedora and EPEL.

Comment 1 Fedora Review Service 2024-06-07 12:52:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7554824
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290871-foosnapper/fedora-rawhide-x86_64/07554824-foosnapper/fedora-review/review.txt

Found issues:

- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/foosnapper/diff.txt
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
- Systemd service file(s) in foosnapper
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Kim B. Heino 2024-06-07 13:19:33 UTC
> - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/foosnapper/diff.txt

Spec refers to release 1.2 but SRPM was built against git head snapshot / git tarball. I'll do new 1.3 release before submitting foosnapper to Fedora to fix this.

> - Systemd service file(s) in foosnapper

Missing "%systemd_postun foosnapper.service" added in upstream https://github.com/FoobarOy/foosnapper/commit/c9db3c91085d00f62fdad4b97c9ace9086028af3

> foosnapper.noarch: E: spelling-error ('snapshooter', 'Summary(en_US) snapshooter -> snap shooter, snap-shooter, snaps hooter')
> foosnapper.noarch: E: spelling-error ('snapshooter', '%description -l en_US snapshooter -> snap shooter, snap-shooter, snaps hooter')
> foosnapper.src: E: spelling-error ('snapshooter', 'Summary(en_US) snapshooter -> snap shooter, snap-shooter, snaps hooter')
> foosnapper.src: E: spelling-error ('snapshooter', '%description -l en_US snapshooter -> snap shooter, snap-shooter, snaps hooter')

"snapshoot" is renamed to more common "snapshot" (also: snapshooter -> snapshotter) in upstream https://github.com/FoobarOy/foosnapper/commit/4330a489c00df71c8cfac33a3d2932788cbdc20b

> foosnapper.noarch: E: non-readable /etc/foosnapper/foosnapper.conf 640

Fixed in upstream https://github.com/FoobarOy/foosnapper/commit/4f2d324abc8b75716f35fb8e7c7c6b19a6c1e999

Comment 3 Paul Wouters 2024-06-19 00:35:01 UTC
Can you please publish the 1.3 upstream and update the spec and srpm so that I can pull in everything and run fedora-review without manually packaging up stuff. This always avoids us trusting your promise instead of your code :)

Comment 4 Kim B. Heino 2024-06-19 11:08:00 UTC
Spec URL: https://heino.kim/foosnapper/foosnapper.spec
SRPM URL: https://heino.kim/foosnapper/foosnapper-1.3-1.fc40.src.rpm

Version 1.3 released.

Comment 5 Fedora Review Service 2024-06-19 11:16:02 UTC
Created attachment 2037801 [details]
The .spec file difference from Copr build 7554824 to 7627461

Comment 6 Fedora Review Service 2024-06-19 11:16:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7627461
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290871-foosnapper/fedora-rawhide-x86_64/07627461-foosnapper/fedora-review/review.txt

Found issues:

- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/foosnapper/diff.txt
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
- Systemd service file(s) in foosnapper
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Kim B. Heino 2024-06-19 11:59:50 UTC
Spec URL: https://heino.kim/foosnapper/foosnapper.spec
SRPM URL: https://heino.kim/foosnapper/foosnapper-1.3-1.fc40.src.rpm

Let's try one more time to get correct md5sum.

I don't understand what's wrong with systemd services.

Comment 8 Fedora Review Service 2024-06-19 12:05:54 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7627569
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2290871-foosnapper/fedora-rawhide-x86_64/07627569-foosnapper/fedora-review/review.txt

Found issues:

- Systemd service file(s) in foosnapper
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.