Releases retrieved: 3.10.4 Upstream release that is considered latest: 3.10.4 Current version/release in rawhide: 3.10.3-1.fc41 URL: https://pypi.org/project/orjson/ Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/ More information about the service that created this bug can be found at: https://docs.fedoraproject.org/en-US/package-maintainers/Upstream_Release_Monitoring Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream. Based on the information from Anitya: https://release-monitoring.org/project/31737/ To change the monitoring settings for the project, please visit: https://src.fedoraproject.org/rpms/python-orjson
Created attachment 2036933 [details] Update to 3.10.4 (#2291190)
the-new-hotness/release-monitoring.org's scratch build of python-orjson-3.10.4-1.fc40.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=118846646
Releases retrieved: 3.10.5 Upstream release that is considered latest: 3.10.5 Current version/release in rawhide: 3.10.3-2.fc41 URL: https://pypi.org/project/orjson/ Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/ More information about the service that created this bug can be found at: https://docs.fedoraproject.org/en-US/package-maintainers/Upstream_Release_Monitoring Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream. Based on the information from Anitya: https://release-monitoring.org/project/31737/ To change the monitoring settings for the project, please visit: https://src.fedoraproject.org/rpms/python-orjson
Created attachment 2037192 [details] Update to 3.10.5 (#2291190)
the-new-hotness/release-monitoring.org's scratch build of python-orjson-3.10.5-1.fc40.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=118989602
Releases retrieved: 3.10.6 Upstream release that is considered latest: 3.10.6 Current version/release in rawhide: 3.10.3-2.fc41 URL: https://pypi.org/project/orjson/ Please consult the package updates policy before you issue an update to a stable branch: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/ More information about the service that created this bug can be found at: https://docs.fedoraproject.org/en-US/package-maintainers/Upstream_Release_Monitoring Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream. Based on the information from Anitya: https://release-monitoring.org/project/31737/ To change the monitoring settings for the project, please visit: https://src.fedoraproject.org/rpms/python-orjson
Created attachment 2038887 [details] Update to 3.10.6 (#2291190)
the-new-hotness/release-monitoring.org's scratch build of python-orjson-3.10.6-1.fc40.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=119943860
Seems to be failing with: error: no matching package named `unwinding` found Some new rust package that is necessary? Have there been any efforts to resolve this?
(In reply to Brian J. Murrell from comment #9) > Seems to be failing with: > > error: no matching package named `unwinding` found > > Some new rust package that is necessary? Have there been any efforts to > resolve this? This has to do with the way that maturin checks for all dependencies for all features, and when it does it. It is kind of rigid and frustrating, but also a familiar thing to deal with. It shows up in the automated scratch build because a new “unwind” crate feature was added, which makes maturin look for the unwinding crate – which exists, but hasn’t been installed at the time the check runs. At a glance, since the comment above the new feature says “Avoid bundling libgcc on musl,” this new feature is probably useless on Fedora and should just be patched out in %prep. This is the sort of thing a human considers when updating the package; automatic scratch builds for updated Rust packages are particularly unlikely to be fully correct. I don’t think anyone has tried to update past 3.10.3, because 3.10.4, 3.10.5, and 3.10.6 all have only “improve performance” in the changelogs. Not that performance isn’t important, but it’s not a major motivation for doing the work to get every single upstream patch release into Rawhide.
I did basically that in https://download.copr.fedorainfracloud.org/results/brianjmurrell/homeassistant-staging/fedora-40-x86_64/07719895-python-orjson/python-orjson.spec by reverting the patch from upstream that added it. Of course, if it can be done more easily in %prep, give 'er. :-)
https://src.fedoraproject.org/rpms/python-orjson/pull-request/14
Nice solution. Shows what little (i.e. nothing) I know about Cargo and crates and all of that goop. :-)
FEDORA-2024-92a7543ff8 (python-orjson-3.10.6-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-92a7543ff8
FEDORA-2024-92a7543ff8 (python-orjson-3.10.6-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
Will this be updated in the currently supported (and used by most users) Fedora 40?
(In reply to Brian J. Murrell from comment #16) > Will this be updated in the currently supported (and used by most users) > Fedora 40? This is a question for the primary maintainer, @maxwell. I do not know the original reason for updating only Rawhide to 3.10.6. Looking at https://github.com/ijl/orjson/releases, I see “sdist uses metadata 2.3 instead of 2.1” in the release notes for 3.10.0. I don’t think that needs to be considered a breaking change, but maybe there’s something I’m missing. If Maxwell wants to update stable branches, I’m happy to do a quick impact check and actually take care of it. If you only want this because the homeassistant components tend to pin their dependencies very tightly or to exact versions, e.g. https://github.com/home-assistant/core/blob/dev/pyproject.toml, please understand that pinning dependencies tightly, especially down to the patch release, is incompatible with distribution packaging except in very special cases, since everyone needs to use the same versions of everything. Fedora packages can’t respect such strict version pins in general, and patching them out is the correct way forward. Even when such strict bounds can be made to work here and there, it’s not reasonable for library package maintainers to have to coordinate patching version bounds in large numbers of dependent packages every time they do a minor update.
Hi, thanks for reaching out. Apologies for being out of the loop a bit--I've been very busy the past few months and came down with COVID earlier this week. Orjson is just a JSON (de)serializer with a stable interface, so I'm fine with updating the stable branches (though I would happily accept help from the python-packagers-sig), but I strongly echo Ben's point about version pinning. It might work for upstreams, but it's definitely incompatible with what we do in a distribution like Fedora.
Hope you feel better soon! I opened PR’s for updating stable branches, and posed the question of whether to switch to rpmautospec in https://src.fedoraproject.org/rpms/python-orjson/pull-request/17#comment-212140. https://src.fedoraproject.org/rpms/python-orjson/pull-request/17 https://src.fedoraproject.org/rpms/python-orjson/pull-request/18
FEDORA-2024-1a10349cf3 (python-orjson-3.10.6-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1a10349cf3
FEDORA-2024-cab1b6da2f (python-orjson-3.10.6-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-cab1b6da2f
FEDORA-2024-1a10349cf3 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1a10349cf3` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1a10349cf3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-cab1b6da2f has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-cab1b6da2f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-cab1b6da2f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-cab1b6da2f (python-orjson-3.10.6-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-1a10349cf3 (python-orjson-3.10.6-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.