Bug 2291231 - Review Request: rust-dsl_auto_type - Automatically expand query fragment types for factoring as functions
Summary: Review Request: rust-dsl_auto_type - Automatically expand query fragment type...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/dsl_auto_type
Whiteboard:
Depends On:
Blocks: 2284104
TreeView+ depends on / blocked
 
Reported: 2024-06-10 21:22 UTC by Fabio Valentini
Modified: 2024-07-13 18:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-13 18:33:36 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-06-10 21:22:56 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-dsl_auto_type.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-dsl_auto_type-0.1.0-1.fc40.src.rpm

Description:
Automatically expand query fragment types for factoring as functions.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-06-10 21:22:58 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=118850629

Comment 2 Fedora Review Service 2024-06-10 21:32:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7592536
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2291231-rust-dsl_auto_type/fedora-rawhide-x86_64/07592536-rust-dsl_auto_type/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2024-07-11 20:09:09 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged => please update to 0.1.1 when importing
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fabio Valentini 2024-07-13 15:35:21 UTC
Thank you for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2024-07-13 15:37:42 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dsl_auto_type

Comment 6 Fedora Update System 2024-07-13 16:52:18 UTC
FEDORA-2024-74d4a3001f (rust-diesel-2.2.1-1.fc41, rust-diesel_derives-2.2.1-1.fc41, and 2 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-74d4a3001f

Comment 7 Fedora Update System 2024-07-13 18:33:36 UTC
FEDORA-2024-74d4a3001f (rust-diesel-2.2.1-1.fc41, rust-diesel_derives-2.2.1-1.fc41, and 2 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.