Bug 2291276 - Review Request: qaccessibilityclient-qt5 - Accessibility client library for Qt5
Summary: Review Request: qaccessibilityclient-qt5 - Accessibility client library for Qt5
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Beck Liu
QA Contact: Fedora Extras Quality Assurance
URL: https://invent.kde.org/libraries/libq...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-06-11 07:18 UTC by Felix Wang
Modified: 2024-06-12 16:36 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-12 15:53:26 UTC
Type: ---
Embargoed:
shattuckite: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2024-06-11 07:29:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7593776
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2291276-qaccessibilityclient-qt5/fedora-rawhide-x86_64/07593776-qaccessibilityclient-qt5/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Beck Liu 2024-06-11 14:44:47 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Creative Commons CC0 1.0", "Unknown or generated", "GNU Lesser
     General Public License, Version 2.1", "GNU Lesser General Public
     License, Version 3", "*No copyright* GNU Lesser General Public
     License, Version 3". 16 files have unknown license. Detailed output of
     licensecheck in /var/lib/copr-rpmbuild/results/qaccessibilityclient-
     qt5/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/include, /usr/src, /usr/lib64/cmake,
     /usr/src/debug, /usr/share, /usr/share/qlogging-categories5,
     /usr/share/doc, /usr, /usr/share/licenses, /usr/lib64, /usr/lib
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/licenses,
     /usr/share, /usr/include, /usr/src, /usr/lib, /usr/share/qlogging-
     categories5, /usr/share/doc, /usr/lib64/cmake, /usr, /usr/src/debug,
     /usr/lib64
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2139 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     qaccessibilityclient-qt5-devel
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: qaccessibilityclient-qt5-0.6.0-1.fc41.x86_64.rpm
          qaccessibilityclient-qt5-devel-0.6.0-1.fc41.x86_64.rpm
          qaccessibilityclient-qt5-debuginfo-0.6.0-1.fc41.x86_64.rpm
          qaccessibilityclient-qt5-debugsource-0.6.0-1.fc41.x86_64.rpm
          qaccessibilityclient-qt5-0.6.0-1.fc41.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpaevzwh4y')]
checks: 32, packages: 5

qaccessibilityclient-qt5-devel.x86_64: W: no-documentation
 5 packages and 0 specfiles checked; 0 errors, 1 warnings, 26 filtered, 0 badness; has taken 0.6 s 




Rpmlint (debuginfo)
-------------------
Checking: qaccessibilityclient-qt5-debuginfo-0.6.0-1.fc41.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpj6idna8v')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.2 s 





Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "qaccessibilityclient-qt5-devel".
(none): E: there is no installed rpm "qaccessibilityclient-qt5-debugsource".
(none): E: there is no installed rpm "qaccessibilityclient-qt5-debuginfo".
(none): E: there is no installed rpm "qaccessibilityclient-qt5".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://invent.kde.org/libraries/libqaccessibilityclient/-/archive/v0.6.0/libqaccessibilityclient-v0.6.0.tar.bz2 :
  CHECKSUM(SHA256) this package     : 1e3261a9c90af466fb1835749ff6ea94052e829d71b421bbbccd5fd2efcd022c
  CHECKSUM(SHA256) upstream package : 1e3261a9c90af466fb1835749ff6ea94052e829d71b421bbbccd5fd2efcd022c


Requires
--------
qaccessibilityclient-qt5 (rpmlib, GLIBC filtered):
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5DBus.so.5()(64bit)
    libQt5DBus.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    rtld(GNU_HASH)

qaccessibilityclient-qt5-devel (rpmlib, GLIBC filtered):
    cmake-filesystem(x86-64)
    libqaccessibilityclient-qt5.so.0()(64bit)
    qaccessibilityclient-qt5-(x86-64)

qaccessibilityclient-qt5-debuginfo (rpmlib, GLIBC filtered):

qaccessibilityclient-qt5-debugsource (rpmlib, GLIBC filtered):



Provides
--------
qaccessibilityclient-qt5:
    libqaccessibilityclient-qt5.so.0()(64bit)
    qaccessibilityclient-qt5
    qaccessibilityclient-qt5(x86-64)

qaccessibilityclient-qt5-devel:
    cmake(QAccessibilityClient)
    cmake(qaccessibilityclient)
    qaccessibilityclient-qt5-devel
    qaccessibilityclient-qt5-devel(x86-64)

qaccessibilityclient-qt5-debuginfo:
    debuginfo(build-id)
    libqaccessibilityclient-qt5.so.0.6.0-0.6.0-1.fc41.x86_64.debug()(64bit)
    qaccessibilityclient-qt5-debuginfo
    qaccessibilityclient-qt5-debuginfo(x86-64)

qaccessibilityclient-qt5-debugsource:
    qaccessibilityclient-qt5-debugsource
    qaccessibilityclient-qt5-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name qaccessibilityclient-qt5 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Haskell, SugarActivity, Perl, Java, Ocaml, fonts, R, PHP, Python
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 3 Beck Liu 2024-06-12 14:45:08 UTC
[x] package name is OK
[x] license is acceptable for Fedora
[x] builds and installs OK
[x] BR/P/R look correct
[x] There are no big rpmlint issues.

Approved.

Comment 4 Fedora Admin user for bugzilla script actions 2024-06-12 14:45:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/qaccessibilityclient-qt5

Comment 5 Fedora Update System 2024-06-12 14:59:26 UTC
FEDORA-2024-a84cee1412 (qaccessibilityclient-qt5-0.6.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a84cee1412

Comment 6 Fedora Update System 2024-06-12 15:53:26 UTC
FEDORA-2024-a84cee1412 (qaccessibilityclient-qt5-0.6.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Miro Hrončok 2024-06-12 16:13:00 UTC
The package does not install:

 nothing provides qaccessibilityclient-qt5-(x86-64) = 0.6.0-1.fc41 needed by qaccessibilityclient-qt5-devel-0.6.0-1.fc41.x86_64

Comment 8 Felix Wang 2024-06-12 16:36:52 UTC
(In reply to Miro Hrončok from comment #7)
> The package does not install:
> 
>  nothing provides qaccessibilityclient-qt5-(x86-64) = 0.6.0-1.fc41 needed by
> qaccessibilityclient-qt5-devel-0.6.0-1.fc41.x86_64

Many thanks for seeing this. It will be resolved in https://src.fedoraproject.org/rpms/qaccessibilityclient-qt5/c/3d8cab3758fb358e1c13300144a873b6bdcd7af0?branch=rawhide


Note You need to log in before you can comment on or make changes to this bug.