Bug 2291306 - Review Request: rust-scc - Containers and utilities for concurrent and asynchronous programming
Summary: Review Request: rust-scc - Containers and utilities for concurrent and asynch...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2291307
Blocks: 2276319
TreeView+ depends on / blocked
 
Reported: 2024-06-11 12:30 UTC by Fabio Valentini
Modified: 2024-08-02 22:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-08-02 22:45:10 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-06-11 12:30:49 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-scc.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-scc-2.1.1-1.fc40.src.rpm

Description:
High performance containers and utilities for concurrent and
asynchronous programming.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2024-06-11 12:32:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7596219
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2291306-rust-scc/fedora-rawhide-x86_64/07596219-rust-scc/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Michel Lind 2024-08-01 15:01:28 UTC
Approved with nits
- update to 2.1.6
- can you add an exclude for .config and .github?

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged => please update to 2.1.6 when importing
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

## Review template (compat)

Compat package, looks identical to the existing rust-$crate. APPROVED

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard -R rust-$crate$ver` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fabio Valentini 2024-08-02 18:38:42 UTC
Thank you for the review!

Comment 4 Fedora Update System 2024-08-02 22:40:55 UTC
FEDORA-2024-dbb1c9f276 (rust-proptest-1.5.0-1.fc41, rust-proptest-macro-0.1.0-1.fc41, and 4 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-dbb1c9f276

Comment 5 Fedora Update System 2024-08-02 22:45:10 UTC
FEDORA-2024-dbb1c9f276 (rust-proptest-1.5.0-1.fc41, rust-proptest-macro-0.1.0-1.fc41, and 4 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.