Copr build:
https://copr.fedorainfracloud.org/coprs/build/7609818
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292035-flowblade/fedora-rawhide-x86_64/07609818-flowblade/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- The License field must be a valid SPDX expression.
  Note: Not a valid SPDX expression 'GPLv3'. It seems that you are using
  the old Fedora license abbreviations. Try `license-fedora2spdx' for
  converting it to SPDX.
  See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

Apart from the license tag, it looks good to go.

===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GNU General Public License, Version 3", "*No copyright* GNU
     General Public License, Version 3", "Unknown or generated", "GNU
     General Public License v3.0 or later and/or GNU General Public
     License, Version 2", "GNU General Public License v3.0 or later". 946
     files have unknown license. Detailed output of licensecheck in
     /var/lib/copr-rpmbuild/results/flowblade/licensecheck.txt
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/bin, /usr/share/locale/it, /usr/lib,
     /usr/share/locale/ru, /usr/share/locale/zh_TW, /usr/share/locale/uk,
     /usr/share, /usr/share/licenses, /usr/share/locale/de/LC_MESSAGES,
     /usr/share/locale/cs/LC_MESSAGES, /usr/share/locale/zh_TW/LC_MESSAGES,
     /usr/share/locale/fr, /usr/share/locale/hu/LC_MESSAGES,
     /usr/share/man/man1, /usr/share/locale/tr, /usr, /usr/share/locale/pl,
     /usr/share/locale, /usr/share/metainfo,
     /usr/share/locale/tr/LC_MESSAGES, /usr/share/locale/cs,
     /usr/share/icons/hicolor/128x128, /usr/share/locale/es/LC_MESSAGES,
     /usr/share/locale/hu, /usr/share/locale/it/LC_MESSAGES,
     /usr/share/icons/hicolor/128x128/apps, /usr/share/man,
     /usr/share/mime, /usr/share/icons/hicolor,
     /usr/share/locale/pl/LC_MESSAGES, /usr/share/locale/ru/LC_MESSAGES,
     /usr/share/locale/zh_CN/LC_MESSAGES, /usr/share/locale/zh_CN,
     /usr/share/doc, /usr/share/icons, /usr/share/locale/uk/LC_MESSAGES,
     /usr/share/mime/packages, /usr/share/applications,
     /usr/lib/python3.12, /usr/share/locale/es,
     /usr/share/locale/fr/LC_MESSAGES, /usr/lib/python3.12/site-packages,
     /usr/share/locale/de
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/metainfo,
     /usr/share/man, /usr/share/locale/cs/LC_MESSAGES, /usr/share/mime,
     /usr/share/icons/hicolor, /usr/share/locale/pl/LC_MESSAGES,
     /usr/share/locale/zh_TW/LC_MESSAGES, /usr/share/locale/ru/LC_MESSAGES,
     /usr/share/locale/fr, /usr/bin, /usr/share/locale/zh_CN/LC_MESSAGES,
     /usr/share/locale/zh_CN, /usr/share/doc, /usr/share/icons,
     /usr/share/locale/hu/LC_MESSAGES, /usr/share/locale/tr/LC_MESSAGES,
     /usr/share/man/man1, /usr/share/locale/cs, /usr/share/locale/tr,
     /usr/share/locale/uk/LC_MESSAGES, /usr/share/mime/packages, /usr,
     /usr/share/locale/it, /usr/share/icons/hicolor/128x128,
     /usr/share/locale/pl, /usr/lib, /usr/share/applications,
     /usr/share/icons/hicolor/128x128/apps, /usr/lib/python3.12,
     /usr/share/locale/ru, /usr/share/locale/es/LC_MESSAGES,
     /usr/share/locale/es, /usr/share/locale/hu,
     /usr/share/locale/fr/LC_MESSAGES, /usr/share/locale/zh_TW,
     /usr/share/locale, /usr/share/locale/uk, /usr/share,
     /usr/share/licenses, /usr/share/locale/de/LC_MESSAGES,
     /usr/share/locale/it/LC_MESSAGES, /usr/lib/python3.12/site-packages,
     /usr/share/locale/de
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
     Note: Multiple Release: tags found
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 53 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: flowblade-2.16.2-2.fc41.noarch.rpm
          flowblade-2.16.2-2.fc41.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpvv10or7b')]
checks: 32, packages: 2

flowblade.noarch: E: zero-length /usr/lib/python3.12/site-packages/Flowblade/res/css3/sass/_applications.scss
flowblade.noarch: E: spelling-error ('Multitrack', 'Summary(en_US) Multitrack -> Multi track, Multi-track, Multiracial')
flowblade.src: E: spelling-error ('Multitrack', 'Summary(en_US) Multitrack -> Multi track, Multi-track, Multiracial')
flowblade.noarch: E: files-duplicated-waste 119560
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/vieweditor/__init__.py /usr/lib/python3.12/site-packages/Flowblade/__init__.py:/usr/lib/python3.12/site-packages/Flowblade/tools/__init__.py
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/checkbox-checked.png /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/checkbox-checked-dark.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/switch-active.png /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/switch-active-header.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/switch-active /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/switch-active-header
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/switch-active-insensitive.png /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/switch-active-insensitive-header.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/switch-active-insensitive /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/switch-active-insensitive-header
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/titlebutton-maximize-active.png /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/titlebutton-maximize-active-dark.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/titlebutton-maximize-active /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/titlebutton-maximize-active-dark
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/titlebutton-minimize-active.png /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/titlebutton-minimize-active-dark.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/titlebutton-minimize-active /usr/lib/python3.12/site-packages/Flowblade/res/css3/assets/titlebutton-minimize-active-dark
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/media_panel_empty /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/media_panel_empty.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/oneroll_noedit_cursor /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/oneroll_cursor
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/unused_indicator.png /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/show_unused_files.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/slide_noedit_cursor /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/slide_cursor
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/tworoll_noedit_cursor /usr/lib/python3.12/site-packages/Flowblade/res/darktheme/tworoll_cursor
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/help/ru/all_comp.png /usr/lib/python3.12/site-packages/Flowblade/res/help/en/all_comp.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/help/ru/header_text_5.png /usr/lib/python3.12/site-packages/Flowblade/res/help/en/header_text_5.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/help/ru/only_one_comp.png /usr/lib/python3.12/site-packages/Flowblade/res/help/en/only_one_comp.png
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/help/ru/tocgen.js /usr/lib/python3.12/site-packages/Flowblade/res/help/en/tocgen.js
flowblade.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/Flowblade/res/help/ru/workflow.png /usr/lib/python3.12/site-packages/Flowblade/res/help/en/workflow.png
flowblade.noarch: E: explicit-lib-dependency librsvg2
flowblade.noarch: W: desktopfile-without-binary /usr/share/applications/io.github.jliljebl.Flowblade.desktop env
 2 packages and 0 specfiles checked; 5 errors, 21 warnings, 10 filtered, 5 badness; has taken 1.4 s 




Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "flowblade".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/jliljebl/flowblade/archive/v2.16.2/flowblade-2.16.2.tar.gz :
  CHECKSUM(SHA256) this package     : 53c6d153ae8b14ae4c4bda704ef7f0e989d895a9037c70f0654ac5a28699a6fb
  CHECKSUM(SHA256) upstream package : 53c6d153ae8b14ae4c4bda704ef7f0e989d895a9037c70f0654ac5a28699a6fb


Requires
--------
flowblade (rpmlib, GLIBC filtered):
    /usr/bin/bash
    /usr/bin/ffmpeg
    /usr/bin/python3
    frei0r-plugins
    gmic
    gtk3
    ladspa-swh-plugins
    librsvg2
    python(abi)
    python3-dbus
    python3-gobject
    python3-libusb1
    python3-mlt
    python3-numpy
    python3-pillow
    shared-mime-info(x86-64)



Provides
--------
flowblade:
    application()
    application(io.github.jliljebl.Flowblade.desktop)
    flowblade
    metainfo()
    metainfo(io.github.jliljebl.Flowblade.appdata.xml)
    mimehandler(application/vnd.flowblade-project)
    python3.12dist(flowblade)
    python3dist(flowblade)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name flowblade --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Perl, fonts, PHP, Haskell, Ocaml, SugarActivity, C/C++, Java, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Oh, one more thing.

Please check if
Requires: python3-gobject
could be changed to:
Requires: python3-gobject-base

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/flowblade.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/flowblade-2.16.2-3.fc40.src.rpm

%changelog
* Sun Jun 16 2024 Martin Gansser <martinkg> - 2.16.2-3
- Changed RR python3-gobject to python3-gobject-base

Created attachment 2037516 [details]
The .spec file difference from Copr build 7609818 to 7619068

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7619068
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292035-flowblade/fedora-rawhide-x86_64/07619068-flowblade/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks good now, thanks! APPROVED

The Pagure repository was created at https://src.fedoraproject.org/rpms/flowblade