Spec URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-macros.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-macros-0.8.1-1.fc39/rust-relm4-macros-0.8.1-1.fc40.src.rpm Description: Idiomatic GUI library inspired by Elm and based on gtk4-rs Fedora Account System Username: jsteffan
Copr build: https://copr.fedorainfracloud.org/coprs/build/7617811 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292548-rust-relm4-macros/fedora-rawhide-x86_64/07617811-rust-relm4-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This crate doesn't include license texts. Both MIT and Apache-2.0 licenses require that redistributed sources contain a copy of the license text. Please file an issue with the upstream project about including the MIT and Apache-2.0 license texts in all published crates. PS: > # error[E0432]: unresolved import `relm4` This usually means that test dependencies would introduce a dependency loop (in this case, relm4-macros -> relm4 -> relm4-macros), and hence tests can only be compiled and run when building inside the upstream git repo / cargo workspace.
https://github.com/Relm4/Relm4/issues/655 filed for all of the relm4 crates.
You can temporarily include the license texts from https://github.com/Relm4/Relm4 manually until upstream publishes new versions with the license texts included. Here's a package where I had to do this recently that can serve as an example of how to do it: https://src.fedoraproject.org/rpms/rust-zune-jpeg/blob/rawhide/f/rust-zune-jpeg.spec#_15
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-macros.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-macros-0.8.1-1.fc39/rust-relm4-macros-0.8.1-1.fc40.src.rpm
Two minor things that don't block review: - Please improve the comment why tests are disabled. "tests can only be run in-tree / in a git checkout" or something like that is more meaningful that just pasting the error message. - Version 0.9.0 was released recently. I assume you still need v0.8, so this is fine? === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (disabled with justification) 🫤 latest version of the crate is packaged (0.9.0 is out) ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files (manually included from upstream) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-macros.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-macros-0.8.1-1.fc39/rust-relm4-macros-0.8.1-1.fc40.src.rpm Staying with 0.7 series as the 0.8 upgrade requires a bunch of updates to existing package. That can be done in rawhide after getting these batch through.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-relm4-macros
Staying with 0.8 series as the 0.9 upgrade requires a bunch of updates to existing package. That can be done in rawhide after getting these batch through.
FEDORA-2024-465a0d9603 (rust-relm4-macros-0.8.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-465a0d9603
FEDORA-2024-465a0d9603 (rust-relm4-macros-0.8.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.