Spec URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07621332-python-huggingface-hub/python-huggingface-hub.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07621332-python-huggingface-hub/python-huggingface-hub-0.23.4-1.fc41.src.rpm Description: The huggingface_hub library allows you to interact with the Hugging Face Hub, a machine learning platform for creators and collaborators. Discover pre-trained models and datasets for your projects or play with the hundreds of machine learning apps hosted on the Hub. You can also create and share your own models and datasets with the community. The huggingface_hub library provides a simple way to do all these things with Python. Fedora Account System Username: msuchy
Copr build: https://copr.fedorainfracloud.org/coprs/build/7621375 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292665-python-huggingface-hub/fedora-rawhide-x86_64/07621375-python-huggingface-hub/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'Apache 2.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated Spec URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07623824-python-huggingface-hub/python-huggingface-hub.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07623824-python-huggingface-hub/python-huggingface-hub-0.23.4-1.fc41.src.rpm
Created attachment 2037668 [details] The .spec file difference from Copr build 7621375 to 7623833
Copr build: https://copr.fedorainfracloud.org/coprs/build/7623833 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292665-python-huggingface-hub/fedora-rawhide-x86_64/07623833-python-huggingface-hub/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'Apache 2.0'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "*No copyright* Apache License", "Apache License 2.0", "*No copyright* MIT License". 65 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/python-huggingface- hub/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.13, /usr/lib, /usr/share/licenses, /usr, /usr/share, /usr/bin, /usr/share/doc, /usr/lib/python3.13/site-packages [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc, /usr/share, /usr/lib, /usr/lib/python3.13, /usr/bin, /usr/share/licenses, /usr/lib/python3.13/site-packages, /usr [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6967 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-huggingface-hub-0.23.4-1.fc41.noarch.rpm python-huggingface-hub-0.23.4-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnrk8ywaa')] checks: 32, packages: 2 python-huggingface-hub.src: E: spelling-error ('repos', 'Summary(en_US) repos -> ropes, reps, repose') python-huggingface-hub.src: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') python3-huggingface-hub.noarch: E: spelling-error ('repos', 'Summary(en_US) repos -> ropes, reps, repose') python3-huggingface-hub.noarch: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/commands/huggingface_cli.py 644 /usr/bin/env python python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/utils/__init__.py 644 /usr/bin/env python python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/utils/_subprocess.py 644 /usr/bin/env python python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/utils/tqdm.py 644 /usr/bin/env python python3-huggingface-hub.noarch: W: no-manual-page-for-binary huggingface-cli python-huggingface-hub.src: W: invalid-license Apache 2.0 python3-huggingface-hub.noarch: W: invalid-license Apache 2.0 2 packages and 0 specfiles checked; 8 errors, 3 warnings, 15 filtered, 8 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-huggingface-hub". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/h/huggingface_hub/huggingface_hub-0.23.4.tar.gz : CHECKSUM(SHA256) this package : 35d99016433900e44ae7efe1c209164a5a81dbbcd53a52f99c281dcd7ce22431 CHECKSUM(SHA256) upstream package : 35d99016433900e44ae7efe1c209164a5a81dbbcd53a52f99c281dcd7ce22431 Requires -------- python3-huggingface-hub (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.13dist(filelock) python3.13dist(fsspec) python3.13dist(packaging) python3.13dist(pyyaml) python3.13dist(requests) python3.13dist(tqdm) python3.13dist(typing-extensions) Provides -------- python3-huggingface-hub: python-huggingface-hub python3-huggingface-hub python3.13-huggingface-hub python3.13dist(huggingface-hub) python3dist(huggingface-hub) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-huggingface-hub --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: Java, Ocaml, Perl, C/C++, SugarActivity, R, Haskell, PHP, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "*No copyright* Apache License", "Apache License 2.0", "*No copyright* MIT License". 65 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/python-huggingface- hub/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib, /usr/bin, /usr/share, /usr, /usr/share/licenses, /usr/lib/python3.13, /usr/share/doc, /usr/lib/python3.13/site-packages [-]: Package must own all directories that it creates. Note: Directories without known owners: /usr, /usr/lib, /usr/share/licenses, /usr/lib/python3.13, /usr/bin, /usr/share/doc, /usr/lib/python3.13/site-packages, /usr/share [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6967 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-huggingface-hub-0.23.4-1.fc41.noarch.rpm python-huggingface-hub-0.23.4-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpkh1fw46x')] checks: 32, packages: 2 python-huggingface-hub.src: E: spelling-error ('repos', 'Summary(en_US) repos -> ropes, reps, repose') python-huggingface-hub.src: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') python3-huggingface-hub.noarch: E: spelling-error ('repos', 'Summary(en_US) repos -> ropes, reps, repose') python3-huggingface-hub.noarch: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/commands/huggingface_cli.py 644 /usr/bin/env python python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/utils/__init__.py 644 /usr/bin/env python python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/utils/_subprocess.py 644 /usr/bin/env python python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/utils/tqdm.py 644 /usr/bin/env python python3-huggingface-hub.noarch: W: no-manual-page-for-binary huggingface-cli 2 packages and 0 specfiles checked; 8 errors, 1 warnings, 15 filtered, 8 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-huggingface-hub". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/h/huggingface_hub/huggingface_hub-0.23.4.tar.gz : CHECKSUM(SHA256) this package : 35d99016433900e44ae7efe1c209164a5a81dbbcd53a52f99c281dcd7ce22431 CHECKSUM(SHA256) upstream package : 35d99016433900e44ae7efe1c209164a5a81dbbcd53a52f99c281dcd7ce22431 Requires -------- python3-huggingface-hub (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.13dist(filelock) python3.13dist(fsspec) python3.13dist(packaging) python3.13dist(pyyaml) python3.13dist(requests) python3.13dist(tqdm) python3.13dist(typing-extensions) Provides -------- python3-huggingface-hub: python-huggingface-hub python3-huggingface-hub python3.13-huggingface-hub python3.13dist(huggingface-hub) python3dist(huggingface-hub)
Clearing the flag as Jiri is not Fedora's packager and cannot finish the review.
> # if you are missing somewhere and the dependencies are in fedora, let me know to enable it > #%%pyproject_extras_subpkg -n python3-huggingface-hub cli,,fastai,hf-transfer,inference,quality,tensorflow,tensorflow-testing,testing,torch,typing I am not quite sure what you are trying to say here (and in the same comment bellow). > # For official Fedora packages, including files with '*' +auto is not allowed > # Replace it with a list of relevant Python modules/globs and list extra files in %%files A leftover autogenerated comment, can be removed > %check They have tests in the upstream repository which would be nice to run. But they are not present in the PyPI tarball. If you prefer the PyPI tarball, can you please add a comment in the %check phase that we are not running the tests because they are not available there? Otherwise LGTM
Comments added. Including one why I commented `%pyproject_extras_subpkg` - it is new thing for me. I cannot enable it now because missing dependencies and I will forget how to enable it later. Leftover removed. Updated. Spec URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07627135-python-huggingface-hub/python-huggingface-hub.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07627135-python-huggingface-hub/python-huggingface-hub-0.23.4-1.fc41.src.rpm
Created attachment 2037777 [details] The .spec file difference from Copr build 7623833 to 7627139
Copr build: https://copr.fedorainfracloud.org/coprs/build/7627139 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2292665-python-huggingface-hub/fedora-rawhide-x86_64/07627139-python-huggingface-hub/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "*No copyright* Apache License", "Apache License 2.0", "*No copyright* MIT License". 65 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/python-huggingface- hub/licensecheck.txt Note: The MIT License for the repocard.py file is a false-positive [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.13/site-packages, /usr/bin, /usr/share, /usr/lib, /usr, /usr/share/licenses, /usr/share/doc, /usr/lib/python3.13 [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib, /usr/bin, /usr/share/doc, /usr/share, /usr, /usr/lib/python3.13, /usr/share/licenses [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6967 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-huggingface-hub-0.23.4-1.fc41.noarch.rpm python-huggingface-hub-0.23.4-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpykqjstn7')] checks: 32, packages: 2 python-huggingface-hub.src: E: spelling-error ('repos', 'Summary(en_US) repos -> ropes, reps, repose') python-huggingface-hub.src: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') python3-huggingface-hub.noarch: E: spelling-error ('repos', 'Summary(en_US) repos -> ropes, reps, repose') python3-huggingface-hub.noarch: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/commands/huggingface_cli.py 644 /usr/bin/env python python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/utils/__init__.py 644 /usr/bin/env python python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/utils/_subprocess.py 644 /usr/bin/env python python3-huggingface-hub.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/huggingface_hub/utils/tqdm.py 644 /usr/bin/env python python3-huggingface-hub.noarch: W: no-manual-page-for-binary huggingface-cli 2 packages and 0 specfiles checked; 8 errors, 1 warnings, 15 filtered, 8 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-huggingface-hub". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/h/huggingface_hub/huggingface_hub-0.23.4.tar.gz : CHECKSUM(SHA256) this package : 35d99016433900e44ae7efe1c209164a5a81dbbcd53a52f99c281dcd7ce22431 CHECKSUM(SHA256) upstream package : 35d99016433900e44ae7efe1c209164a5a81dbbcd53a52f99c281dcd7ce22431 Requires -------- python3-huggingface-hub (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.13dist(filelock) python3.13dist(fsspec) python3.13dist(packaging) python3.13dist(pyyaml) python3.13dist(requests) python3.13dist(tqdm) python3.13dist(typing-extensions) Provides -------- python3-huggingface-hub: python-huggingface-hub python3-huggingface-hub python3.13-huggingface-hub python3.13dist(huggingface-hub) python3dist(huggingface-hub) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-huggingface-hub --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Ocaml, Java, Haskell, PHP, Perl, C/C++, fonts, SugarActivity, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-huggingface-hub
FEDORA-2024-4e96c1cecf (python-huggingface-hub-0.23.4-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4e96c1cecf
FEDORA-2024-4e96c1cecf has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4e96c1cecf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4e96c1cecf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-4e96c1cecf (python-huggingface-hub-0.23.4-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.