Spec URL: https://gui1ty.fedorapeople.org/review/python-crick.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-crick-0.0.6-1.fc41.src.rpm Description: Crick is a fast library of approximate and streaming algorithms. It is still a work in progress, use at your own risk. Fedora Account System Username: gui1ty `crick` a missing dependency for `dask-expr`.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7627108 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293043-python-crick/fedora-rawhide-x86_64/07627108-python-crick/fedora-review/review.txt Found issues: - python3-crick : /usr/lib64/python3.13/site-packages/crick/common.h python3-crick : /usr/lib64/python3.13/site-packages/crick/klib/khash.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated spec file excluding source and test files. Spec URL: https://gui1ty.fedorapeople.org/review/python-crick.spec SRPM URL: https://gui1ty.fedorapeople.org/review/python-crick-0.0.6-2.fc41.src.rpm
Created attachment 2038400 [details] The .spec file difference from Copr build 7627108 to 7678031
Copr build: https://copr.fedorainfracloud.org/coprs/build/7678031 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293043-python-crick/fedora-rawhide-x86_64/07678031-python-crick/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The header file issue is being referred to upstream at https://github.com/dask/crick/pull/52 . Aside from that, this looks good to me, passes all review requirements. Approved.
Thanks for the review.
FEDORA-2024-a3e2d4e31d (python-crick-0.0.6-1.fc41 and python-dask-expr-1.1.6-4.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a3e2d4e31d
FEDORA-2024-a3e2d4e31d (python-crick-0.0.6-1.fc41 and python-dask-expr-1.1.6-4.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.