Spec URL: http://developer.postgresql.org/~devrim/rpms/other/pgpool-II/postgresql-pgpoolAdmin.spec SRPM URL: http://developer.postgresql.org/~devrim/rpms/other/pgpool-II/postgresql-pgpoolAdmin-1.0.0-5.src.rpm Description: The pgpool Administration Tool is management tool of pgpool-II. It is possible to monitor, start, stop pgpool and change settings of pgpool-II.
rpmlint on SRPM: W: postgresql-pgpoolAdmin mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Should be an easy fix. on RPM: W: postgresql-pgpoolAdmin symlink-should-be-relative /usr/share/postgresql-pgpoolAdmin/conf/pgmgt.conf.php /etc/postgresql-pgpoolAdmin/pgmgt.conf.php Absolute symlinks are problematic eg. when working with chroot environments. W: postgresql-pgpoolAdmin dangerous-command-in-%post chmod Instead of chmod in %post, set permissions with an %attr tag on the %files section. Much safer.
Ping?
Pong:) New spec: http://developer.postgresql.org/~devrim/rpms/other/pgpool-II/postgresql-pgpoolAdmin.spec New SRPM: http://developer.postgresql.org/~devrim/rpms/other/pgpool-II/postgresql-pgpoolAdmin-1.0.0-6.src.rpm Removed chmod calls, and updated the pgpool-II package to solve that issue. Also fixed whitespace issue. rpmlint complains about user apache, but it is ignorable (per Tibbs). The only issue left is the symlink problem -- I could not understand that well. Regards, Devrim
Looking good. Basically, for the symlink issue, replace: ln -s %{_sysconfdir}/%{name}/pgmgt.conf.php %{buildroot}/%{_pgpoolAdmindir}/conf/pgmgt.conf.php with: ln -s ../../../../%{_sysconfdir}/%{name}/pgmgt.conf.php %{buildroot}/%{_pgpoolAdmindir}/conf/pgmgt.conf.php Good to see you're back. I was beginning to think we*'d invaded Turkey and the media was ignoring it, or something. Wouldn't put it past us, sadly. :) Just hit a busy patch? *I'm USian.
Hi, (In reply to comment #4) > Looking good. > > Basically, for the symlink issue, replace: <snip> Done. Thanks. > Good to see you're back. I was beginning to think we*'d invaded Turkey and > the media was ignoring it, or something. Wouldn't put it past us, sadly. :) Heh. > Just hit a busy patch? No, I was busy with Turkey's biggest "Linux and Open Source Festival" + work issues. Anyway, I did not bump up spec file version; but updated SRPM: New spec: http://developer.postgresql.org/~devrim/rpms/other/pgpool-II/postgresql-pgpoolAdmin.spec New SRPM: http://developer.postgresql.org/~devrim/rpms/other/pgpool-II/postgresql-pgpoolAdmin-1.0.0-6.src.rpm Is it ok? Regards, Devrim
Is someone actually reviewing this? It's still marked as NEW and the fedora-review flag is unset.
Yes. I believe the expression is D'oh! Sorry.
Extra / in line 43: ln -s ../../../../%{_sysconfdir}/%{name}/pgmgt.conf.php %{buildroot}/%{_pgpoolAdmindir}/conf/pgmgt.conf.php should be ln -s ../../../..%{_sysconfdir}/%{name}/pgmgt.conf.php %{buildroot}%{_pgpoolAdmindir}/conf/pgmgt.conf.php Mock build fails with: RPM build errors: File not found: /var/tmp/postgresql-pgpoolAdmin-1.0.0-6.fc6-root-mockbuild/etc/httpd/conf.d/postgresql-pgpoolAdmin.conf Looks like the conditional at line 46 is failing due to a BuildRequires issue. Are you sure you don't want that to just install it no matter what?
Hi Jon, (In reply to comment #8) > Extra / in line 43: > ln -s ../../../../%{_sysconfdir}/%{name}/pgmgt.conf.php > %{buildroot}/%{_pgpoolAdmindir}/conf/pgmgt.conf.php > > should be > > ln -s ../../../..%{_sysconfdir}/%{name}/pgmgt.conf.php > %{buildroot}%{_pgpoolAdmindir}/conf/pgmgt.conf.php 'k , fixed. > Mock build fails with: > RPM build errors: > File not found: > /var/tmp/postgresql-pgpoolAdmin-1.0.0-6.fc6-root-mockbuild/etc/httpd/conf.d/postgresql-pgpoolAdmin.conf > > Looks like the conditional at line 46 is failing due to a BuildRequires issue. Added httpd as a BuildRequires. > Are you sure you don't want that to just install it no matter what? It is required for security reasons + easy configuration for users. I did not bump up spec file version; but updated SRPM: New spec: http://developer.postgresql.org/~devrim/rpms/other/pgpool-II/postgresql-pgpoolAdmin.spec New SRPM: http://developer.postgresql.org/~devrim/rpms/other/pgpool-II/postgresql-pgpoolAdmin-1.0.0-6.src.rpm Regards, Devrim
Those check out, I'll do the formal review soon.
rpmlint now clean, save the acceptible error above. Package and spec names are good. Meets packaging guidelines. Not sure what to make of the licensing. Spec says BSD, license appears BSD-ish. Might want to run it by spot but I think it's OK. Spec is legible American English. Source md5 matches. Builds on i386/f7. BuildRequires are good. Locales OK. No libraries, not relocatable. Owns all created dirs. No duplicate files or incorrect permissions. %clean present and correct. Macros sane. Code, not content. No large docs or runtime doc deps. No headers, .pc or .la. No subpackages. Not a gui app. No known conflicts. (Don't forget to fix postgresql-pgpool-II, BTW :)) Install starts by clearing buildroot. All filenames UTF8. All MUSTs met. APPROVED.
New Package CVS Request ======================= Package Name: postgresql-pgpoolAdmin Short Description: Web based pgpool-II administration Owners: devrim Branches: EL-4 EL-5 FC-6 F-7 InitialCC: devrim
cvs done. No need to list yourself as owner and in CC. Also fedora-cvs should be set to ? for a request, and we set it to + when it's processed.