Spec URL: https://peter.fedorapeople.org/packages/erlang-gun.spec SRPM URL: https://peter.fedorapeople.org/packages/erlang-gun-2.1.0-1.fc40.src.rpm Description: Erlang HTTP client with support for HTTP/1.1, HTTP/2, Websocket and more. Fedora Account System Username: peter Koji scratchbuild for Rawhide: * https://koji.fedoraproject.org/koji/taskinfo?taskID=119347732
Copr build: https://copr.fedorainfracloud.org/coprs/build/7630021 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293369-erlang-gun/fedora-rawhide-x86_64/07630021-erlang-gun/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I will take this review.
Minor nitpick: note the mixed-use-of-spaces-and-tabs rpmlint warning. Please clean that up before checking in. This package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "ISC License", "Unknown or generated". 99 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2293369-erlang-gun/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1365 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Known issue. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: erlang-gun-2.1.0-1.fc41.noarch.rpm erlang-gun-2.1.0-1.fc41.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa7h29xft')] checks: 32, packages: 2 erlang-gun.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 4) erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_app.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_app.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_conns_sup.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_conns_sup.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_content_handler.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_content_handler.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_cookies.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_cookies.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_cookies_list.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_cookies_list.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_data_h.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_data_h.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_default_event_h.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_default_event_h.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_event.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_event.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_http.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_http.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_http2.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_http2.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_pool.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_pool.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_pool_events_h.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_pool_events_h.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_pools_sup.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_pools_sup.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_protocols.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_protocols.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_public_suffix.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_public_suffix.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_raw.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_raw.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_socks.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_socks.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_sse_h.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_sse_h.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_sup.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_sup.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_tcp.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_tcp.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_tcp_proxy.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_tcp_proxy.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_tls.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_tls.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_tls_proxy.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_tls_proxy.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_tls_proxy_cb.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_tls_proxy_cb.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_tls_proxy_http2_connect.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_tls_proxy_http2_connect.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_tunnel.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_tunnel.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_ws.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_ws.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_ws_h.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_ws_h.erl erlang-gun.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/gun-2.1.0/ebin/gun_ws_protocol.beam /builddir/build/BUILD/erlang-gun-2.1.0-build/gun-2.1.0/src/gun_ws_protocol.erl ========== 2 packages and 0 specfiles checked; 0 errors, 31 warnings, 8 filtered, 0 badness; has taken 0.2 s =========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/ninenines/gun/archive/2.1.0/gun-2.1.0.tar.gz : CHECKSUM(SHA256) this package : f7ecea9343cf84d53dace3b5a6c781136c8362f4f86c4fc7f8ec8149ba203f53 CHECKSUM(SHA256) upstream package : f7ecea9343cf84d53dace3b5a6c781136c8362f4f86c4fc7f8ec8149ba203f53 Requires -------- erlang-gun (rpmlib, GLIBC filtered): erlang-cowlib erlang-erts(x86-64) erlang-kernel(x86-64) erlang-public_key(x86-64) erlang-runtime_tools(x86-64) erlang-ssl(x86-64) erlang-stdlib(x86-64) Provides -------- erlang-gun: erlang-gun Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2293369 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, PHP, SugarActivity, C/C++, R, Ruby, Python, Perl, Ocaml, fonts, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks! And I've just fixed spacing issue.
The Pagure repository was created at https://src.fedoraproject.org/rpms/erlang-gun
FEDORA-2024-56cca83faf (erlang-gun-2.1.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-56cca83faf
FEDORA-2024-a08d254edf (erlang-gun-2.1.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a08d254edf
FEDORA-2024-56cca83faf has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-56cca83faf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-56cca83faf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-a08d254edf has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a08d254edf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a08d254edf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-a08d254edf (erlang-gun-2.1.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-56cca83faf (erlang-gun-2.1.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.