Spec URL: https://qulogic.fedorapeople.org/reviews/golang-github-charlievieth-fastwalk/golang-github-charlievieth-fastwalk.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/golang-github-charlievieth-fastwalk/golang-github-charlievieth-fastwalk-1.0.4-1.fc39.src.rpm Description: Fast parallel directory traversal for Golang.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7650157 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293755-golang-github-charlievieth-fastwalk/fedora-rawhide-x86_64/07650157-golang-github-charlievieth-fastwalk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
spec is correct, but I've one question: > %bcond check 1 go2rpm template uses bcond_without and has done it since the beginning: https://gitlab.com/fedora/sigs/go/go2rpm/-/blob/main/go2rpm/templates/profile2.spec?ref_type=heads&blame=1#L2 Is there a reason to change it?
I find this style to be clearer (it says what it is, not what it isn't), and it's available on all Fedora. I don't know about EPEL though. But we should probably change it in the template as well.
Eclipseo is proposing similar template change in https://gitlab.com/fedora/sigs/go/go2rpm/-/merge_requests/13 so I guess we'll end adopting it. This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance Thanks!
Thank you for the review, Mikel
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-charlievieth-fastwalk
FEDORA-2024-4ddca6fe36 (golang-github-charlievieth-fastwalk-1.0.4-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4ddca6fe36
FEDORA-2024-4ddca6fe36 (golang-github-charlievieth-fastwalk-1.0.4-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7d3cf57455 (fzf-0.53.0-1.fc39, golang-github-charlievieth-fastwalk-1.0.4-1.fc39, and 2 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7d3cf57455
FEDORA-2024-9f26b3eb12 (fzf-0.53.0-1.fc40, golang-github-charlievieth-fastwalk-1.0.4-1.fc40, and 2 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9f26b3eb12
FEDORA-2024-7d3cf57455 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7d3cf57455` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7d3cf57455 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-9f26b3eb12 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9f26b3eb12` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9f26b3eb12 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-9f26b3eb12 (fzf-0.53.0-1.fc40, golang-github-charlievieth-fastwalk-1.0.4-1.fc40, and 2 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7d3cf57455 (fzf-0.53.0-1.fc39, golang-github-charlievieth-fastwalk-1.0.4-1.fc39, and 2 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.