Spec URL: https://music.fedorapeople.org/rust-onefetch-ascii.spec SRPM URL: https://music.fedorapeople.org/rust-onefetch-ascii-2.21.0-1.fc40.src.rpm Description: Display colorized ascii art to the terminal. Fedora Account System Username: music This is part of onefetch, https://github.com/o2sh/onefetch. The spec file is the unmodified output of rust2rpm.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7650812 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293781-rust-onefetch-ascii/fedora-rawhide-x86_64/07650812-rust-onefetch-ascii/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/onefetch- ascii-2.21.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files Not serious. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /mnt/data/projects/fedora- review/2293781-rust-onefetch-ascii/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- onefetch-ascii-devel , rust-onefetch-ascii+default-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-onefetch-ascii-devel-2.21.0-1.fc41.noarch.rpm rust-onefetch-ascii+default-devel-2.21.0-1.fc41.noarch.rpm rust-onefetch-ascii-2.21.0-1.fc41.src.rpm ========================================================================================================================== rpmlint session starts ========================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpkghudj_o')] checks: 32, packages: 3 rust-onefetch-ascii+default-devel.noarch: W: no-documentation ==================================================================================== 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 12 filtered, 0 badness; has taken 0.3 s ===================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 rust-onefetch-ascii+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/onefetch-ascii/2.21.0/download#/onefetch-ascii-2.21.0.crate : CHECKSUM(SHA256) this package : 3a3cd8f0c4cf0b41bf7dea8a7bc5b66de0be4c2a93d0388f4b1d8f7d0b372376 CHECKSUM(SHA256) upstream package : 3a3cd8f0c4cf0b41bf7dea8a7bc5b66de0be4c2a93d0388f4b1d8f7d0b372376 Requires -------- rust-onefetch-ascii-devel (rpmlib, GLIBC filtered): (crate(owo-colors/default) >= 3.5.0 with crate(owo-colors/default) < 4.0.0~) cargo rust-onefetch-ascii+default-devel (rpmlib, GLIBC filtered): cargo crate(onefetch-ascii) Provides -------- rust-onefetch-ascii-devel: crate(onefetch-ascii) rust-onefetch-ascii-devel rust-onefetch-ascii+default-devel: crate(onefetch-ascii/default) rust-onefetch-ascii+default-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2293781 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: R, Perl, Python, Ocaml, PHP, C/C++, Java, Haskell, SugarActivity, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review! https://release-monitoring.org/project/373101/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-onefetch-ascii
FEDORA-2024-f401592944 (rust-onefetch-ascii-2.21.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f401592944
FEDORA-2024-f401592944 (rust-onefetch-ascii-2.21.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-4f15c1edf7 (rust-onefetch-ascii-2.21.0-1.fc40 and rust-onefetch-image-2.21.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f15c1edf7
FEDORA-2024-d8509b61d9 (rust-onefetch-ascii-2.21.0-1.fc39 and rust-onefetch-image-2.21.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d8509b61d9
FEDORA-EPEL-2024-be46877d38 (rust-onefetch-ascii-2.21.0-1.el9 and rust-onefetch-image-2.21.0-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-be46877d38
FEDORA-2024-d8509b61d9 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d8509b61d9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d8509b61d9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-be46877d38 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-be46877d38 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-4f15c1edf7 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4f15c1edf7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f15c1edf7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-be46877d38 (rust-onefetch-ascii-2.21.0-1.el9 and rust-onefetch-image-2.21.0-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-d8509b61d9 (rust-onefetch-ascii-2.21.0-1.fc39 and rust-onefetch-image-2.21.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-4f15c1edf7 (rust-onefetch-ascii-2.21.0-1.fc40 and rust-onefetch-image-2.21.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.