Bug 2293880 - Review Request: golang-cloud-google-auth - Google Cloud Client Libraries for Go for module auth
Summary: Review Request: golang-cloud-google-auth - Google Cloud Client Libraries for ...
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-06-24 04:28 UTC by Robert-André Mauchin 🐧
Modified: 2024-06-30 10:03 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2024-06-24 04:28:57 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-cloud-google-auth.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-cloud-google-auth-0.5.1-1.fc40.src.rpm

Description:
Google Cloud Client Libraries for Go for module auth.

Fedora Account System Username: eclipseo

Comment 2 Fedora Review Service 2024-06-24 04:32:20 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7656948
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2293880-golang-cloud-google-auth/fedora-rawhide-x86_64/07656948-golang-cloud-google-auth/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Mikel Olasagasti Uranga 2024-06-29 15:28:07 UTC
Do you plan to take care of bumping the rest of requried packages? golang-cloud-google-compute-metadata-devel and others.

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 4 Robert-André Mauchin 🐧 2024-06-30 09:57:21 UTC
> Do you plan to take care of bumping the rest of requried packages? golang-cloud-google-compute-metadata-devel and others.

Sadly yes

koji list-tagged f41-build-side-91461
Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
golang-cloud-google-bigquery-1.61.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-cloudtasks-1.12.8-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-compute-1.27.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-compute-metadata-0.3.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-datacatalog-1.20.1-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-datastore-1.17.1-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-firestore-1.15.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-iam-1.1.8-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-kms-1.18.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-logging-1.10.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-longrunning-0.5.7-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-monitoring-1.19.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-osconfig-1.12.7-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-pubsub-1.39.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-secretmanager-1.13.1-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-spanner-1.63.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-storage-1.42.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-cloud-google-trace-1.10.7-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-github-apache-arrow-15.0.2-2.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-github-googleapis-enterprise-certificate-proxy-0.3.2-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-google-api-0.185.0-1.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-x-exp-0-0.55.20240623git7f521ea.fc41~bootstrap  f41-build-side-91461  eclipseo
golang-x-oauth2-0.21.0-2.fc41~bootstrap   f41-build-side-91461  eclipseo
golang-x-telemetry-0-1.20240623gita740542.fc41~bootstrap  f41-build-side-91461  eclipseo

Comment 5 Fedora Admin user for bugzilla script actions 2024-06-30 10:03:49 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-cloud-google-auth


Note You need to log in before you can comment on or make changes to this bug.