Bug 2294566 - Review Request: rust-built - Crate with information from the time it was built
Summary: Review Request: rust-built - Crate with information from the time it was built
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: wojnilowicz
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/built
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-06-27 11:54 UTC by Fabio Valentini
Modified: 2024-07-02 15:44 UTC (History)
2 users (show)

Fixed In Version: rust-built-0.7.3-1.fc41
Clone Of:
Environment:
Last Closed: 2024-07-02 15:44:43 UTC
Type: ---
Embargoed:
lukasz.wojnilowicz: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2024-06-27 11:54:54 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-built.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-built-0.7.3-1.fc40.src.rpm

Description:
Provides a crate with information from the time it was built.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-06-27 11:54:57 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=119689527

Comment 2 Fedora Review Service 2024-06-27 12:03:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7676535
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294566-rust-built/fedora-rawhide-x86_64/07676535-rust-built/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 wojnilowicz 2024-06-28 19:03:00 UTC
Package was generated with rust2rpm (probably with rust2rpm.toml which is not to be found here), simplifying the review.

✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Comment 4 Fabio Valentini 2024-07-02 14:23:33 UTC
Thank you for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2024-07-02 14:24:03 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-built

Comment 6 Fabio Valentini 2024-07-02 15:44:43 UTC
Imported and built.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-cf9c79006f


Note You need to log in before you can comment on or make changes to this bug.