Spec URL: https://jjames.fedorapeople.org/ocaml-ppxlib-jane/ocaml-ppxlib-jane.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-ppxlib-jane/ocaml-ppxlib-jane-0.17.0-1.fc41.src.rpm Fedora Account System Username: jjames Description: A library for use in ppxes for constructing and matching on ASTs corresponding to the augmented parsetree that is recognized by the Jane Street OCaml compiler (flambda). ASTs constructed using this library are compatible with the standard OCaml compiler. Any syntax change known to this library is encoded as attributes, and the standard OCaml compiler's interpretation of the ASTs constructed by these library (which amounts to ignoring the attributes) is reasonable. That is, we only expose "unsurprising" things in this library. For example, if you construct an *n*-ary function using this library, the standard OCaml compiler will interpret it as *n* nested unary functions in the normal way. Likewise, ppxes that use this library to match on Jane Street ASTs can also be used with the standard OCaml compiler. (The Jane Street AST cases of the match will just never be triggered when using the standard OCaml compiler.) This package is needed to update the Jane Street packages from their 0.16.x versions to 0.17.x. The builds have all been done in a COPR: https://copr.fedorainfracloud.org/coprs/jjames/JaneStreet/. I am willing to swap reviews.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7690171 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2294766-ocaml-ppxlib-jane/fedora-rawhide-x86_64/07690171-ocaml-ppxlib-jane/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'll review it
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (MIT_. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format (%autochangelog). [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package requires an ExcludeArch tag since it's OCaml application/library. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1957 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not test if the package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [?]: I did not test if package compiles and builds into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocaml-ppxlib-jane-0.17.0-1.fc41.x86_64.rpm ocaml-ppxlib-jane-devel-0.17.0-1.fc41.x86_64.rpm ocaml-ppxlib-jane-debuginfo-0.17.0-1.fc41.x86_64.rpm ocaml-ppxlib-jane-debugsource-0.17.0-1.fc41.x86_64.rpm ocaml-ppxlib-jane-0.17.0-1.fc41.src.rpm ========================================================================================================================================= rpmlint session starts ======================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpz1utvshu')] checks: 32, packages: 5 ocaml-ppxlib-jane-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ppxlib_jane/ppxlib_jane.a ocaml-ppxlib-jane.src: E: spelling-error ('ppxes', '%description -l en_US ppxes -> poxes, pyxes, poleaxes') ocaml-ppxlib-jane.src: E: spelling-error ('parsetree', '%description -l en_US parsetree -> parse tree, parse-tree, parentheses') ocaml-ppxlib-jane.src: E: spelling-error ('flambda', '%description -l en_US flambda -> lambda, f lambda, lambada') ocaml-ppxlib-jane.src: E: spelling-error ('ary', '%description -l en_US ary -> ray, art, aery') ocaml-ppxlib-jane.x86_64: E: spelling-error ('ppxes', '%description -l en_US ppxes -> poxes, pyxes, poleaxes') ocaml-ppxlib-jane.x86_64: E: spelling-error ('parsetree', '%description -l en_US parsetree -> parse tree, parse-tree, parentheses') ocaml-ppxlib-jane.x86_64: E: spelling-error ('flambda', '%description -l en_US flambda -> lambda, f lambda, lambada') ocaml-ppxlib-jane.x86_64: E: spelling-error ('ary', '%description -l en_US ary -> ray, art, aery') ocaml-ppxlib-jane-devel.x86_64: W: no-documentation =================================================================================================== 5 packages and 0 specfiles checked; 9 errors, 1 warnings, 20 filtered, 9 badness; has taken 2.5 s =================================================================================================== Rpmlint (debuginfo) ------------------- Checking: ocaml-ppxlib-jane-debuginfo-0.17.0-1.fc41.x86_64.rpm ========================================================================================================================================= rpmlint session starts ======================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp80kzja_k')] checks: 32, packages: 1 ==================================================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.4 s =================================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 ocaml-ppxlib-jane-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ppxlib_jane/ppxlib_jane.a ocaml-ppxlib-jane.x86_64: E: spelling-error ('ppxes', '%description -l en_US ppxes -> poxes, pyxes, poleaxes') ocaml-ppxlib-jane.x86_64: E: spelling-error ('parsetree', '%description -l en_US parsetree -> parse tree, parse-tree, parentheses') ocaml-ppxlib-jane.x86_64: E: spelling-error ('flambda', '%description -l en_US flambda -> lambda, f lambda, lambada') ocaml-ppxlib-jane.x86_64: E: spelling-error ('ary', '%description -l en_US ary -> ray, art, aery') ocaml-ppxlib-jane-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 5 errors, 1 warnings, 17 filtered, 5 badness; has taken 1.6 s Source checksums ---------------- https://github.com/janestreet/ppxlib_jane/archive/v0.17.0/ppxlib_jane-0.17.0.tar.gz : CHECKSUM(SHA256) this package : 42757d7b44a5f2a766778e6b4710100c6ef9d0c074eb3e7fa4c69647336d8398 CHECKSUM(SHA256) upstream package : 42757d7b44a5f2a766778e6b4710100c6ef9d0c074eb3e7fa4c69647336d8398 Requires -------- ocaml-ppxlib-jane (rpmlib, GLIBC filtered): ocaml(Astlib) ocaml(Astlib__) ocaml(Astlib__Ast_402) ocaml(Astlib__Ast_403) ocaml(Astlib__Ast_404) ocaml(Astlib__Ast_405) ocaml(Astlib__Ast_406) ocaml(Astlib__Ast_407) ocaml(Astlib__Ast_408) ocaml(Astlib__Ast_409) ocaml(Astlib__Ast_410) ocaml(Astlib__Ast_411) ocaml(Astlib__Ast_412) ocaml(Astlib__Ast_413) ocaml(Astlib__Ast_414) ocaml(Astlib__Ast_500) ocaml(Astlib__Ast_501) ocaml(Astlib__Ast_502) ocaml(Astlib__Location) ocaml(Astlib__Longident) ocaml(Astlib__Parse) ocaml(Astlib__Pprintast) ocaml(Asttypes) ocaml(Build_path_prefix_map) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(Clflags) ocaml(Cmi_format) ocaml(Compmisc) ocaml(Docstrings) ocaml(Env) ocaml(Ident) ocaml(Identifiable) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Misc) ocaml(Ocaml_common) ocaml(Outcometree) ocaml(Parsetree) ocaml(Path) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast_helper_lite) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Versions) ocaml(Ppxlib_jane__) ocaml(Ppxlib_jane__Ast_builder_intf) ocaml(Ppxlib_jane__Jane_asttypes) ocaml(Ppxlib_jane__Jane_syntax) ocaml(Ppxlib_jane__Jane_syntax_parsing) ocaml(Ppxlib_jane__Language_extension) ocaml(Ppxlib_jane__Language_extension_kernel) ocaml(Ppxlib_jane__Shadow_compiler_distribution) ocaml(Primitive) ocaml(Profile) ocaml(Sexplib0) ocaml(Sexplib0__) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_grammar) ocaml(Sexplib0__Sexp_grammar) ocaml(Shape) ocaml(Stdlib) ocaml(Stdlib__Arg) ocaml(Stdlib__Buffer) ocaml(Stdlib__Bytes) ocaml(Stdlib__BytesLabels) ocaml(Stdlib__Char) ocaml(Stdlib__Digest) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__Hashtbl) ocaml(Stdlib__Lazy) ocaml(Stdlib__Lexing) ocaml(Stdlib__List) ocaml(Stdlib__ListLabels) ocaml(Stdlib__Map) ocaml(Stdlib__Option) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__Set) ocaml(Stdlib__StdLabels) ocaml(Stdlib__String) ocaml(Stdlib__StringLabels) ocaml(Stdlib__Sys) ocaml(Stdlib__Uchar) ocaml(Stdppx) ocaml(Subst) ocaml(Type_immediacy) ocaml(Types) ocaml(Unit_info) ocaml(Warnings) rtld(GNU_HASH) ocaml-ppxlib-jane-devel (rpmlib, GLIBC filtered): ocaml(Astlib) ocaml(Astlib__) ocaml(Astlib__Ast_402) ocaml(Astlib__Ast_403) ocaml(Astlib__Ast_404) ocaml(Astlib__Ast_405) ocaml(Astlib__Ast_406) ocaml(Astlib__Ast_407) ocaml(Astlib__Ast_408) ocaml(Astlib__Ast_409) ocaml(Astlib__Ast_410) ocaml(Astlib__Ast_411) ocaml(Astlib__Ast_412) ocaml(Astlib__Ast_413) ocaml(Astlib__Ast_414) ocaml(Astlib__Ast_500) ocaml(Astlib__Ast_501) ocaml(Astlib__Ast_502) ocaml(Astlib__Location) ocaml(Astlib__Longident) ocaml(Astlib__Parse) ocaml(Astlib__Pprintast) ocaml(Asttypes) ocaml(Build_path_prefix_map) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(Clflags) ocaml(Cmi_format) ocaml(Compmisc) ocaml(Docstrings) ocaml(Env) ocaml(Ident) ocaml(Identifiable) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Misc) ocaml(Ocaml_common) ocaml(Outcometree) ocaml(Parsetree) ocaml(Path) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast_helper_lite) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Versions) ocaml(Ppxlib_jane__) ocaml(Ppxlib_jane__Ast_builder_intf) ocaml(Ppxlib_jane__Jane_asttypes) ocaml(Ppxlib_jane__Jane_syntax) ocaml(Ppxlib_jane__Jane_syntax_parsing) ocaml(Ppxlib_jane__Language_extension) ocaml(Ppxlib_jane__Language_extension_kernel) ocaml(Ppxlib_jane__Shadow_compiler_distribution) ocaml(Primitive) ocaml(Profile) ocaml(Sexplib0) ocaml(Sexplib0__) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_grammar) ocaml(Sexplib0__Sexp_grammar) ocaml(Shape) ocaml(Stdlib) ocaml(Stdlib__Arg) ocaml(Stdlib__Buffer) ocaml(Stdlib__Bytes) ocaml(Stdlib__BytesLabels) ocaml(Stdlib__Char) ocaml(Stdlib__Digest) ocaml(Stdlib__Domain) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__Hashtbl) ocaml(Stdlib__Lazy) ocaml(Stdlib__Lexing) ocaml(Stdlib__List) ocaml(Stdlib__ListLabels) ocaml(Stdlib__Map) ocaml(Stdlib__Option) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__Set) ocaml(Stdlib__StdLabels) ocaml(Stdlib__String) ocaml(Stdlib__StringLabels) ocaml(Stdlib__Sys) ocaml(Stdlib__Uchar) ocaml(Stdppx) ocaml(Subst) ocaml(Type_immediacy) ocaml(Types) ocaml(Unit_info) ocaml(Warnings) ocaml-ppxlib-devel(x86-64) ocaml-ppxlib-jane(x86-64) ocamlx(Astlib__Pprintast) ocamlx(CamlinternalFormat) ocamlx(Location) ocamlx(Longident) ocamlx(Misc) ocamlx(Ppxlib_ast__Ast_helper_lite) ocamlx(Ppxlib_jane__Ast_builder_intf) ocamlx(Ppxlib_jane__Jane_asttypes) ocamlx(Ppxlib_jane__Jane_syntax) ocamlx(Ppxlib_jane__Jane_syntax_parsing) ocamlx(Ppxlib_jane__Language_extension) ocamlx(Ppxlib_jane__Language_extension_kernel) ocamlx(Ppxlib_jane__Shadow_compiler_distribution) ocamlx(Stdlib) ocamlx(Stdlib__Bytes) ocamlx(Stdlib__Format) ocamlx(Stdlib__List) ocamlx(Stdlib__Option) ocamlx(Stdlib__Printf) ocamlx(Stdlib__String) ocamlx(Stdppx) ocamlx(Warnings) ocaml-ppxlib-jane-debuginfo (rpmlib, GLIBC filtered): ocaml-ppxlib-jane-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-ppxlib-jane: ocaml(Ppxlib_jane) ocaml(Ppxlib_jane__) ocaml(Ppxlib_jane__Ast_builder) ocaml(Ppxlib_jane__Ast_builder_intf) ocaml(Ppxlib_jane__Jane_asttypes) ocaml(Ppxlib_jane__Jane_syntax) ocaml(Ppxlib_jane__Jane_syntax_parsing) ocaml(Ppxlib_jane__Language_extension) ocaml(Ppxlib_jane__Language_extension_kernel) ocaml(Ppxlib_jane__Shadow_compiler_distribution) ocaml-ppxlib-jane ocaml-ppxlib-jane(x86-64) ocaml-ppxlib-jane-devel: ocaml(Ppxlib_jane) ocaml(Ppxlib_jane__) ocaml(Ppxlib_jane__Ast_builder) ocaml(Ppxlib_jane__Ast_builder_intf) ocaml(Ppxlib_jane__Jane_asttypes) ocaml(Ppxlib_jane__Jane_syntax) ocaml(Ppxlib_jane__Jane_syntax_parsing) ocaml(Ppxlib_jane__Language_extension) ocaml(Ppxlib_jane__Language_extension_kernel) ocaml(Ppxlib_jane__Shadow_compiler_distribution) ocaml-ppxlib-jane-devel ocaml-ppxlib-jane-devel(x86-64) ocamlx(Ppxlib_jane) ocamlx(Ppxlib_jane__) ocamlx(Ppxlib_jane__Ast_builder) ocamlx(Ppxlib_jane__Ast_builder_intf) ocamlx(Ppxlib_jane__Jane_asttypes) ocamlx(Ppxlib_jane__Jane_syntax) ocamlx(Ppxlib_jane__Jane_syntax_parsing) ocamlx(Ppxlib_jane__Language_extension) ocamlx(Ppxlib_jane__Language_extension_kernel) ocamlx(Ppxlib_jane__Shadow_compiler_distribution) ocaml-ppxlib-jane-debuginfo: debuginfo(build-id) ocaml-ppxlib-jane-debuginfo ocaml-ppxlib-jane-debuginfo(x86-64) ocaml-ppxlib-jane-debugsource: ocaml-ppxlib-jane-debugsource ocaml-ppxlib-jane-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2294766 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++, Ocaml Disabled plugins: PHP, Perl, SugarActivity, Python, R, Haskell, fonts, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH This package is ================ === APPROVED === ================
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ppxlib-jane
Version 0.17.0 has been built in Rawhide.