Bug 2295950 - BLAS/LAPACK linking
Summary: BLAS/LAPACK linking
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dlib
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Sandro
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-07-05 12:02 UTC by Iñaki Ucar
Modified: 2024-07-15 05:32 UTC (History)
5 users (show)

Fixed In Version: dlib-19.24.4-14.fc41 dlib-19.24.4-14.fc40 dlib-19.24.4-13.fc39
Clone Of:
Environment:
Last Closed: 2024-07-06 13:17:28 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Fedora Package Sources dlib pull-request 15 0 None None None 2024-07-06 10:27:58 UTC

Description Iñaki Ucar 2024-07-05 12:02:50 UTC
The packaging guidelines establishes that BLAS/LAPACK-dependent packages MUST link against FlexiBLAS, instead of the reference implementation or a specific implementation directly, so that this can be managed system-wide (see https://docs.fedoraproject.org/en-US/packaging-guidelines/BLAS_LAPACK/#_packaging_blaslapack_dependent_packages).

This was implemented as part of https://fedoraproject.org/wiki/Changes/FlexiBLAS_as_BLAS/LAPACK_manager,
but reverted in this commit: https://src.fedoraproject.org/rpms/dlib/c/74963b4b2658e40e291d68a2565e87cf23ab8c4f

Please, revert back to linking to FlexiBLAS. Thanks.

Reproducible: Always

Comment 1 Ankur Sinha (FranciscoD) 2024-07-05 12:32:11 UTC
@gui1ty : would you remember why we moved off flexiblas?

Comment 2 Sandro 2024-07-06 07:42:08 UTC
I don't exactly remember why I switched away from flexiblas. I'm pretty sure I was largely unaware of the guidelines linked above and tried to solve some build issue involving BLAS. Apparently, nobody noticed during PR review, either.

Going through the commit history, I can see that in the past a patch was required to allow dlib to find and use flexiblas. I will try to switch back to flexiblas and submit a PR for that. I'll also leave a comment in the spec regarding the guidelines, so other maintainers are aware.

Comment 3 Sandro 2024-07-06 10:27:59 UTC
PR submitted. My scratch build on ppc64le hasn't yet finished, but it looks like a patch is no longer required. Will merge, etc. as soon as the PR CI jobs are giving a green light.

Comment 4 Iñaki Ucar 2024-07-06 10:48:47 UTC
dlib's internal find_blas.cmake ultimately relies on cmake's find_package(BLAS), which finds FlexiBLAS just fine since v3.19.

Comment 5 Fedora Update System 2024-07-06 13:13:43 UTC
FEDORA-2024-208ae87e01 (dlib-19.24.4-14.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-208ae87e01

Comment 6 Fedora Update System 2024-07-06 13:17:28 UTC
FEDORA-2024-208ae87e01 (dlib-19.24.4-14.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-07-06 13:22:13 UTC
FEDORA-2024-f741bb9f01 (dlib-19.24.4-14.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f741bb9f01

Comment 8 Fedora Update System 2024-07-06 13:22:13 UTC
FEDORA-2024-d5ad959ba0 (dlib-19.24.4-13.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d5ad959ba0

Comment 9 Fedora Update System 2024-07-07 02:02:54 UTC
FEDORA-2024-d5ad959ba0 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d5ad959ba0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d5ad959ba0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-07-07 02:09:52 UTC
FEDORA-2024-f741bb9f01 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f741bb9f01`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f741bb9f01

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-07-15 01:28:38 UTC
FEDORA-2024-f741bb9f01 (dlib-19.24.4-14.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-07-15 05:32:03 UTC
FEDORA-2024-d5ad959ba0 (dlib-19.24.4-13.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.